Message-ID: <54C6C79E.1090303@sunrus.com.cn>
Date: Tue, 27 Jan 2015 07:02:54 +0800
From: Chen Gang S <gang.chen@sunrus.com.cn>
MIME-Version: 1.0
References: <54C4DC4E.3080306@sunrus.com.cn>
	<CAFEAcA_hGO-R85yYXDU7eoC7FHF_v96y7Oh54SX9HXBAss6Vpg@mail.gmail.com>
	<54C5672D.4080800@sunrus.com.cn>
	<CAFEAcA9mqzpHsWcyDdzBYDWdxsR1AoDy3akgHCaMUbjZ0zh=0Q@mail.gmail.com>
	<54C6566B.6050205@sunrus.com.cn>
	<CAFEAcA8q7jNqL8DFygnHaiiv=2pGKXBQ_Gi1icOn9H=diOXK5Q@mail.gmail.com>
In-Reply-To: <CAFEAcA8q7jNqL8DFygnHaiiv=2pGKXBQ_Gi1icOn9H=diOXK5Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all
 lock_user_struct() and unlock_user_struct() paired with each other
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel <qemu-devel@nongnu.org>

On 1/26/15 23:01, Peter Maydell wrote:
> On 26 January 2015 at 14:59, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>> On 1/26/15 06:10, Peter Maydell wrote:
>>> I would just like the commit message to be clear about the
>>> scope of the work the patch covers. If the patch is just "Fix
>>> mismatched lock/unlock calls in IPC struct conversion functions"
>>> then that's fine, but the commit message should say that. At the
>>> moment the commit message is very vague.
>>>
>>
>> OK, thanks.
>>
>> I am not quite familiar with this file, so I describe the modification
>> by function name, e.g. lock_user_struct() and unlick_user_struct() in
>> the patch subject.
> 
> In a big file I think it's often more useful to describe the
> functions which are being changed. My suggested subject would be:
> 
> "Fix mismatched lock/unlock calls in IPC struct conversion functions"
> 

What you said above sounds reasonable to me. 
 
> Riku can decide if he wants a v2 or will just fix it up as he
> applies it to his linux-user tree.
> 

OK, thanks.

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed