Message-ID: <54C7B129.90308@msgid.tls.msk.ru>
Date: Tue, 27 Jan 2015 18:39:21 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <54C21D76.8050808@sunrus.com.cn>
In-Reply-To: <54C21D76.8050808@sunrus.com.cn>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for
 using target_vec[i].iov_len instead of target_vec[i].iov_base
To: Chen Gang S <gang.chen@sunrus.com.cn>, riku.voipio@iki.fi
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>

23.01.2015 13:07, Chen Gang S wrote:
> It is only a typo issue, need use tswapal(target_vec[i].iov_len) for the
> len.

My suggestion:

Subject: linux-user/syscall.c: unlock_iovec: fix typo misuse of iov_base instead of iov_len

without further explanation in the message body.

Applied as-is to trivial, thank you!

/mjt

> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a66c2ae..8260ed7 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1896,7 +1896,7 @@ static void unlock_iovec(struct iovec *vec, abi_ulong target_addr,
>      if (target_vec) {
>          for (i = 0; i < count; i++) {
>              abi_ulong base = tswapal(target_vec[i].iov_base);
> -            abi_long len = tswapal(target_vec[i].iov_base);
> +            abi_long len = tswapal(target_vec[i].iov_len);
>              if (len < 0) {
>                  break;
>              }
>