Message-ID: <54F0CC9E.5040807@...1227...> Date: Fri, 27 Feb 2015 20:59:26 +0100 From: Arne Schwabe MIME-Version: 1.0 References: <20150225160718.GA6306@...2009...> <20150227182832.GE8134@...1296...> <20150227192746.GA5936@...2009...> <20150227193452.GF8134@...1296...> In-Reply-To: <20150227193452.GF8134@...1296...> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="R4q1xQ74UACHT3Fr1l1MfVINmVp8NNiE8" Subject: Re: [Openvpn-devel] [PATCH v4] Mac OS X Keychain management client List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gert Doering , Vasily Kulikov Cc: openvpn-devel@lists.sourceforge.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --R4q1xQ74UACHT3Fr1l1MfVINmVp8NNiE8 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable >>> (the diff for doc/management-notes.txt is in there twice), and there >>> is a patch for .gitignore in it as well. >> I've included .gitignore changes as my patch adds Makefile changes. It >> would be rather uncomfortable for openvpn developers to see Makefile and >> be not able to change it. > Mmmh. Actually we don't usually do Makefile changes, as this is always > generated by configure for us - so normally, it is good to have it in > .gitignore. Of course your subdirectory has a Makefile in it for > MacOS X only... > > So - git experts to the rescue - how's this normally done? > > just explicity git add the new Makefile under contrib/keychain-mcd. Git will then track the new makefile. (If I am reading the patch right that the mac os x specific keychain-cmd makefile is not generated by configure) Arne --R4q1xQ74UACHT3Fr1l1MfVINmVp8NNiE8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlTwzJ4ACgkQe8+cMNS4zRczawCfW5RPQUmVEhKOZG+j5OCjySFm EogAoPIgwbU08JdidaoKC4TTRGEn6CYC =sHrg -----END PGP SIGNATURE----- --R4q1xQ74UACHT3Fr1l1MfVINmVp8NNiE8--