From: "Maciej S. Szmigiero" Subject: [PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check Date: Wed, 04 Mar 2015 22:48:30 +0100 Message-ID: <54F77DAE.20005@maciej.szmigiero.name> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Sender: linux-kernel-owner@vger.kernel.org To: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Timur Tabi , Nicolin Chen , Xiubo Li , Liam Girdwood , Mark Brown List-Id: alsa-devel@alsa-project.org of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice, first on assignment then in condition expression. Signed-off-by: Maciej Szmigiero --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1227,7 +1227,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev, ssi_private->dma_params_tx.addr = ssi_private->ssi_phys + CCSR_SSI_STX0; ssi_private->dma_params_rx.addr = ssi_private->ssi_phys + CCSR_SSI_SRX0; - ret = !of_property_read_u32_array(np, "dmas", dmas, 4); + ret = of_property_read_u32_array(np, "dmas", dmas, 4); if (ssi_private->use_dma && !ret && dmas[2] == IMX_DMATYPE_SSI_DUAL) { ssi_private->use_dual_fifo = true; /* When using dual fifo mode, we need to keep watermark