From: David Vrabel Subject: Re: [Xen-devel] [PATCH] xen: avoid NULL pointer dereference in dom0 on large machines Date: Fri, 6 Mar 2015 13:18:30 +0000 Message-ID: <54F9A926.3060108@citrix.com> References: <1424929925-18501-1-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1424929925-18501-1-git-send-email-jgross@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On 26/02/15 05:52, Juergen Gross wrote: > Using the pvops kernel a NULL pointer dereference was detected on a > large machine (144 processors) when booting as dom0 in > evtchn_fifo_unmask() during assignment of a pirq. > > The event channel in question was the first to need a new entry in > event_array[] in events_fifo.c. Unfortunately xen_irq_info_pirq_setup() > is called with evtchn being 0 for a new pirq and the real event channel > number is assigned to the pirq only during __startup_pirq(). > > It is mandatory to call xen_evtchn_port_setup() after assigning the > event channel number to the pirq to make sure all memory needed for the > event channel is allocated. Applied to stable/for-linus-4.0 and tagged for stable, thanks. David