From: Neftin, Sasha Date: Mon, 20 May 2019 09:08:36 +0300 Subject: [Intel-wired-lan] [PATCH] e1000e: Increase pause and refresh time In-Reply-To: References: Message-ID: <5507809f-b2f1-429a-64a7-e59d60c76a4a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 5/17/2019 18:01, Paul Menzel wrote: > From: Miguel Bernal Marin > Date: Mon, 27 Mar 2017 16:01:56 -0600 > > Suggested-by: Tim Pepper > Signed-off-by: Miguel Bernal Marin > Signed-off-by: Paul Menzel > --- > Miguel, it?d be great, if you could write a commit message stating the > motivation for that change, that means, why is it preferable to increase > these values, and set the pause time unconditionally. > > ?drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++-- > ?1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c > b/drivers/net/ethernet/intel/e1000e/netdev.c > index ce4aaa9f2163..597d3ca19555 100644 > --- a/drivers/net/ethernet/intel/e1000e/netdev.c > +++ b/drivers/net/ethernet/intel/e1000e/netdev.c > @@ -4047,12 +4047,12 @@ void e1000e_reset(struct e1000_adapter *adapter) > ???? case e1000_pch_lpt: > ???? case e1000_pch_spt: > ???? case e1000_pch_cnp: > -??????? fc->refresh_time = 0x0400; > +??????? fc->refresh_time = 0xFFFF; > +??????? fc->pause_time = 0xFFFF; > > ???????? if (adapter->netdev->mtu <= ETH_DATA_LEN) { > ???????????? fc->high_water = 0x05C20; > ???????????? fc->low_water = 0x05048; > -??????????? fc->pause_time = 0x0650; > ???????????? break; > ???????? } > I am good with this patch.