Received-SPF: neutral (google.com: 212.227.17.10 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.17.10;
From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH 0/4] Do not DMA on the stack
Date: Sun, 04 Oct 2015 22:39:27 +0200
Message-ID: <5522999.85D2llbvgZ@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <cover.1443989364.git.ksenija.stanojevic@gmail.com>
References: <cover.1443989364.git.ksenija.stanojevic@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Sunday 04 October 2015 22:13:02 Ksenija Stanojevic wrote:
> Fix error "doing DMA on the stack" by using kzalloc for buffer
> allocation in rtl8192u/r8192U_core.c in the following functions:
>         write_nic_byte_E()
>         write_nic_byte()
>         write_nic_word()
>         write_nic_dword()
> Issue found by smatch.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> 
> Ksenija Stanojevic (4):
>   Staging: rtl8192u: Do not DMA on the stack in write_nic_byte_E()
>   Staging: rtl8192u: Do not DMA on the stack in write_nic_byte()
>   Staging: rtl8192u: Do not DMA on the stack in write_nic_word()
>   Staging: rtl8192u: Do not DMA on the stack in write_nic_dword()
> 
 
The changes all look wrong to me, can you guess what the problem is
when you read them again?

Also, these are four instances of the same code, in the same file,
so it would be reasonable to do a single patch, and then you can
do the other five instances in the same file as well.

	Arnd