From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Tue, 07 Apr 2015 19:26:23 +0000
Subject: Re: [PATCH] sh_eth: move inline functions to the header file
Message-Id: <55242F5F.2060409@cogentembedded.com>
List-Id: <linux-sh.vger.kernel.org>
References: <4254119.qJUdUQCUqs@wasted.cogentembedded.com> <20150407.152249.360575010614186977.davem@davemloft.net>
In-Reply-To: <20150407.152249.360575010614186977.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org

Hello.

On 04/07/2015 10:22 PM, David Miller wrote:

>> The explicitly inline functions belong to the header files, so move
>> cpu_to_edmac() and edmac_to_cpu() into the driver header.

>> While at it, make these functions return 'u32' instead of '__u32'.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Then... ummm... remove the inline keyword?

> If it's not used anywhere else, that's the thing to do.

    Results in more code, as I noted in the patch posting that you skipped 
when replying. At least with gcc 4.7.

WBR, Sergei