From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v2 1/2] vtpm: deep quote flags
Date: Wed, 15 Apr 2015 11:07:12 -0400
Message-ID: <552E7EA0.6040709@tycho.nsa.gov>
References: <1429002534-8759-1-git-send-email-emilcondrea@gmail.com>
	<1429002534-8759-2-git-send-email-emilcondrea@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1429002534-8759-2-git-send-email-emilcondrea@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Emil Condrea <emilcondrea@gmail.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 04/14/2015 05:08 AM, Emil Condrea wrote:
> Currently, the flags are not interpreted by vTPM. They are just
> packed and sent to vtpmmgr.
>
> Signed-off-by: Emil Condrea <emilcondrea@gmail.com>

Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>

[...]
> +-	res = TPM_DeepQuote(&nonce, &myPCR, &ptPCR, &req->auth1, &sigSize, &sig);
> ++	res = TPM_DeepQuote(&nonce, &myPCR, &ptPCR, &req->auth1, extraInfoFlags,
> ++		&quote_blob_size, &quote_blob);
> + 	if (res != TPM_SUCCESS) return res;
> +-	rsp->paramSize = len = sigSize;
> ++		rsp->paramSize = len = quote_blob_size;

There's an extra tab at the start of this line.

-- 
Daniel De Graaf
National Security Agency