From: "Jan Beulich" Subject: Re: [PATCH 2/3] x86/hvm: introduce functions for HVMOP_get/set_param allowance checks Date: Wed, 29 Apr 2015 13:29:14 +0100 Message-ID: <5540DCAA02000078000CE04B@mail.emea.novell.com> References: <1429892490-5590-1-git-send-email-paul.durrant@citrix.com> <1429892490-5590-3-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YnR78-0007DC-4V for xen-devel@lists.xenproject.org; Wed, 29 Apr 2015 12:29:18 +0000 In-Reply-To: <1429892490-5590-3-git-send-email-paul.durrant@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: paul.durrant@citrix.com Cc: andrew.cooper3@citrix.com, keir@xen.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org >>> Paul Durrant 04/24/15 6:35 PM >>> >+ /* The following parameters cannot be set by the guest */ Please add a stop ad the end of at least sentence-like comments. >case HVM_PARAM_DM_DOMAIN: >- /* Not reflexive, as we may need to domain_pause(). */ Especially when the reason for not allowing guest access is other than a simple permission thing, I think for documentation purposes it would be useful to retain these comments. a.value = current->domain->domain_id; >+ /* The following parameters cannot be read by the guest */ Perhaps "cannot" isn't the right term here - "shouldn't"? Jan