Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 529ECC47082 for ; Tue, 8 Jun 2021 08:08:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C93661246 for ; Tue, 8 Jun 2021 08:08:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C93661246 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F5D36EB1A; Tue, 8 Jun 2021 08:08:36 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 074D66EB1A; Tue, 8 Jun 2021 08:08:35 +0000 (UTC) IronPort-SDR: qvNzR9zzPnGtBiSwn64ssfKx+qqpOhVU2vIJ/xjt1Ordrp1ztRHipWJ+kbX376CoVRuvJN7ewk sH4uaD6lxsqQ== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="204610721" X-IronPort-AV: E=Sophos;i="5.83,257,1616482800"; d="scan'208";a="204610721" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2021 01:08:34 -0700 IronPort-SDR: 3Mtm9x3YDeZpZOczo72pCSGz6I4Ib/FM6r5jvla9nmqXv64b87sY9cECG/jGUfiFGN1bS+xszr fXeWvg5TyMvQ== X-IronPort-AV: E=Sophos;i="5.83,257,1616482800"; d="scan'208";a="485125341" Received: from mrahim1x-mobl.gar.corp.intel.com (HELO [10.215.170.251]) ([10.215.170.251]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2021 01:08:32 -0700 Subject: Re: [PATCH 4/6] drm/i915/ttm: pass along the I915_BO_ALLOC_CONTIGUOUS To: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-gfx@lists.freedesktop.org References: <20210607182210.99036-1-matthew.auld@intel.com> <20210607182210.99036-5-matthew.auld@intel.com> <044baf68ef8e6fe11941fdb43a9ad404f46c6d3a.camel@linux.intel.com> From: Matthew Auld Message-ID: <55432d48-fd10-4deb-5cb9-8c3d03089cef@intel.com> Date: Tue, 8 Jun 2021 09:08:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <044baf68ef8e6fe11941fdb43a9ad404f46c6d3a.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 08/06/2021 08:26, Thomas Hellström wrote: > Hi, > > On Mon, 2021-06-07 at 19:22 +0100, Matthew Auld wrote: >> Currently we just ignore the I915_BO_ALLOC_CONTIGUOUS flag, which is >> fine since everything is already contiguous with the ttm range >> manager. >> However in the next patch we want to switch over to the ttm buddy >> manager, where allocations are by default not contiguous. >> >> Signed-off-by: Matthew Auld >> Cc: Thomas Hellström >> --- >>  drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 15 ++++++++++++--- >>  1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >> b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >> index 73d52df8f2be..0b0fce445e9b 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >> @@ -86,10 +86,18 @@ i915_ttm_select_tt_caching(const struct >> drm_i915_gem_object *obj) >> >>  static void >>  i915_ttm_place_from_region(const struct intel_memory_region *mr, >> -                          struct ttm_place *place) >> +                          struct ttm_place *place, >> +                          unsigned int flags) >>  { >>         memset(place, 0, sizeof(*place)); >>         place->mem_type = intel_region_to_ttm_type(mr); >> + >> +       switch(mr->type) { >> +       case INTEL_MEMORY_LOCAL: >> +               if (flags & I915_BO_ALLOC_CONTIGUOUS) >> +                       place->flags = TTM_PL_FLAG_CONTIGUOUS; >> +               break; >> +       } > > Do we need to restrict this to INTEL_MEMORY_LOCAL? While it doesn't > currently make much sense for other memory regions, no point in not > forwarding for all? Yeah, don't see why not. > > /Thomas > >