From: "Jan Beulich" Subject: Re: [PATCH v2 2/3] x86/hvm: introduce functions for HVMOP_get/set_param allowance checks Date: Tue, 05 May 2015 10:32:19 +0100 Message-ID: <5548AA4302000078000768F7@mail.emea.novell.com> References: <1430489141-27602-1-git-send-email-paul.durrant@citrix.com> <1430489141-27602-4-git-send-email-paul.durrant@citrix.com> <5543E1E202000078000CE32E@mail.emea.novell.com> <9AAE0902D5BC7E449B7C8E4E778ABCD0258C05FC@AMSPEX01CL01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YpZbU-0006nd-Nd for xen-devel@lists.xenproject.org; Tue, 05 May 2015 09:57:28 +0000 In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD0258C05FC@AMSPEX01CL01.citrite.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant Cc: Andrew Cooper , "Keir(Xen.org)" , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org >>> On 05.05.15 at 11:25, wrote: >> From: Jan Beulich [mailto:jbeulich@suse.com] >> Sent: 01 May 2015 20:28 >> And I continue to think that retaining these comments would be useful for >> documentation purposes (even when switching to white lists - they should >> then remain explicit case labels grouped with the "default" one). And taking >> into consideration the comment change requested at the very top (which >> changes again in the 3rd patch), there could then perhaps be a distinction >> between "can't", "shouldn't", and "mustn't" (again solely serving doc >> purposes). >> > > Ok, if you don't mind have the extra functionally redundant case statements. Yes, I certainly don't mind those if they serve a purpose (documentation). Jan