From: "Jan Beulich" Subject: Re: [PATCH v3 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks Date: Tue, 05 May 2015 15:29:17 +0100 Message-ID: <5548EFDD0200007800076C2F@mail.emea.novell.com> References: <1430821547-5783-1-git-send-email-paul.durrant@citrix.com> <1430821547-5783-4-git-send-email-paul.durrant@citrix.com> <5548A12C.70302@citrix.com> <9AAE0902D5BC7E449B7C8E4E778ABCD0258C14C2@AMSPEX01CL01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ypdqb-0003kZ-IK for xen-devel@lists.xenproject.org; Tue, 05 May 2015 14:29:21 +0000 In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD0258C14C2@AMSPEX01CL01.citrite.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Paul Durrant , "xen-devel@lists.xenproject.org" Cc: "Keir (Xen.org)" List-Id: xen-devel@lists.xenproject.org >>> On 05.05.15 at 16:09, wrote: >> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com] >> Sent: 05 May 2015 11:54 >> On 05/05/15 11:25, Paul Durrant wrote: >> > @@ -5657,21 +5664,11 @@ static int hvm_allow_set_param(struct domain >> *d, >> > case HVM_PARAM_IDENT_PT: >> > case HVM_PARAM_DM_DOMAIN: >> > case HVM_PARAM_ACPI_S_STATE: >> >> I think you can safely elide the above cases into default. All that >> matters in this case is that none of the whitelisted parameters need to >> pause the domain. >> > > I think you and Jan differ there, unless I misunderstood Jan. Right, I specifically asked for these to be retained. It's just that the comment preceding them is not visible from the patch context, so that purpose isn't obvious here. Jan