From: gabriel huau Date: Mon, 11 May 2015 20:34:07 -0700 Subject: [U-Boot] [PATCH 3/4 v2] x86: gpio: add pinctrl support from the device tree In-Reply-To: <553FA5B5.3050502@wwwdotorg.org> References: <1429805775-1809-4-git-send-email-contact@huau-gabriel.fr> <1429993061-10513-1-git-send-email-contact@huau-gabriel.fr> <553FA5B5.3050502@wwwdotorg.org> Message-ID: <555174AF.7000302@huau-gabriel.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stephen, Thanks for the feedback, I completely miss it, I will do the modification for the v3. On 04/28/2015 08:22 AM, Stephen Warren wrote: > On 04/28/2015 07:53 AM, Simon Glass wrote: >> Hi Gabriel, >> >> On 25 April 2015 at 14:17, Gabriel Huau wrote: >>> Every pin can be configured now from the device tree. A dt-bindings >>> has been added to describe the different property available. > >>> diff --git a/include/dt-bindings/gpio/x86-gpio.h >>> b/include/dt-bindings/gpio/x86-gpio.h > >>> +/* >>> + * This header provides constants for binding nvidia,tegra*-gpio. >>> + * >>> + * The first cell in Tegra's GPIO specifier is the GPIO ID. The >>> macros below >>> + * provide names for this. > > I think this comment needs updating. Regards, Gabriel