From: Heiko =?ISO-8859-1?Q?St=FCbner?= Date: Mon, 04 Nov 2019 13:23:27 +0100 Subject: [U-Boot] [PATCH v2 1/2] rockchip: make_fit_atf.py: allow inclusion of a tee binary In-Reply-To: References: <20191006181022.2513-1-heiko@sntech.de> <4ccf8240-fad6-f9bd-5c0d-9f3e8dab24b9@rock-chips.com> Message-ID: <5559676.vajn0TuDnZ@diego> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Simon, Am Mittwoch, 30. Oktober 2019, 02:49:46 CET schrieb Simon Glass: > On Tue, 22 Oct 2019 at 03:45, Kever Yang wrote: > > On 2019/10/22 上午7:46, Simon Glass wrote: > > > On Mon, 14 Oct 2019 at 03:07, Kever Yang wrote: > > >> > > >> On 2019/10/7 上午2:10, Heiko Stuebner wrote: > > >>> A trusted execution environment should also get loaded as loadable from > > >>> a fit image, so add the possibility to present a tee.elf to make_fit_atf.py > > >>> that then gets included as additional loadable into the generated its. > > >>> > > >>> For ease of integration the additional loadable is created as atf_(x+1) > > >>> after all others to re-use core generation loops. > > >>> > > >>> Tested against the combinations of 1-part-atf and multi-part-atf each > > >>> time with and without a tee binary present. > > >>> > > >>> Signed-off-by: Heiko Stuebner > > >> Reviewed-by: Kever Yang > > >> > > >> > > >> Thanks, > > >> - Kever > > >>> --- > > >>> changes in v2: none > > >>> > > >>> arch/arm/mach-rockchip/make_fit_atf.py | 52 +++++++++++++++++++++++--- > > >>> 1 file changed, 46 insertions(+), 6 deletions(-) > > > I see there is an effort to move this to binman. To me that is a much > > > more productive approach! > > > > > > Do you mean the patch set from Jagan for rockchip platform to using binman? > > > > That patch is actually using the output of the u-boot.itb which is based > > on this script. > > > > > > > > Is there a feature or example missing in binman that you need to get > > > this over the hump? > > > > > > I think Heiko and you has a discussion about this in previous version > > thread. > > The U-Boot project build output is: tpl.bin, spl.bin, u-boot.bin > > For rockchip platform, package needs: > > - pack tpl.bin+spl.bin with mkimage -rksd/rkspi into idbloader.img > > - get ATF binaries from bl31.bin/optee.bin with a script > > - generate u-boot.its to describe the u-boot.itb > > - pack u-boot.bin and ATF/OPTEE binaries into u-boot.itb with mkimage -f > > u-boot.its > > > > Does the binman mainly target for pack the idbloader.img+u-boot.itb? > > I actually think binman could handle all of that. > > Is there something I could do that would help with that? I think the main sparse element is time here and maybe a voluteer with enough of time available to lay the groundwork. Like on my personal side, I really don't see me finding the time to actually look at binman and finding out how everything should translate from the current state to binman - soonish. Hooking up new small things into an existing infrastructure is somehow alway easier ;-) . Heiko