From: "Jan Beulich" Subject: Re: [RFC v2 13/15] Update Posted-Interrupts Descriptor during vCPU scheduling Date: Wed, 17 Jun 2015 08:59:58 +0100 Message-ID: <5581451E0200007800085DDF@mail.emea.novell.com> References: <1431076038-7497-1-git-send-email-feng.wu@intel.com> <1431076038-7497-14-git-send-email-feng.wu@intel.com> <5577F8CD0200007800082E0E@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Feng Wu Cc: Kevin Tian , "keir@xen.org" , "george.dunlap@eu.citrix.com" , "andrew.cooper3@citrix.com" , "xen-devel@lists.xen.org" , Yang Z Zhang List-Id: xen-devel@lists.xenproject.org >>> On 17.06.15 at 09:00, wrote: >> From: Jan Beulich [mailto:JBeulich@suse.com] >> Sent: Wednesday, June 10, 2015 2:44 PM >> >>> On 08.05.15 at 11:07, wrote: >> > --- a/xen/include/xen/sched.h >> > +++ b/xen/include/xen/sched.h >> > @@ -142,6 +142,8 @@ struct vcpu >> > >> > int processor; >> > >> > + int pre_pcpu; >> >> This again doesn't belong into the common structure (and should >> be accompanied by a comment, and should be unsigned int). > > I added three new member to 'struct vcpu' in this series: > - struct tasklet vcpu_wakeup_tasklet; > - struct list_head blocked_vcpu_list; > - int pre_pcpu; > > I am trying to find a place specific to vmx to put them in, but the only one > I find is ' struct arch_vmx_struct ', however, I don't think this is a good > place, since it contains all vt-x stuff defined in the SDM. Do you think > 'struct hvm_vcpu' is the right place? No, arch_vmx_struct is. Taking active_list and active_cpu as example, the structure clearly isn't limited to fields defined by the SDM. Jan