From: Maarten Lankhorst Subject: Re: [PATCH 1/3] drm: atomic-helper: Implement drm_atomic_helper_duplicate_state() Date: Tue, 11 Aug 2015 13:51:11 +0200 Message-ID: <55C9E1AF.9030801@linux.intel.com> References: <1439293065-15941-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 2273F6E53C for ; Tue, 11 Aug 2015 04:51:13 -0700 (PDT) In-Reply-To: <1439293065-15941-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGV5LAoKVGhpcyBwYXRjaCBzZXJpZXMgd291bGQgYmUgbGVzcyBjb21wbGljYXRlZCBpZiB5b3Ug YXNzdW1lIHRoZSBjYWxsZXIgbG9ja2VkIHdpdGggZHJtX21vZGVzZXRfbG9ja19hbGwKYW5kIHVz ZSB0aGUgZ2xvYmFsIGFjcXVpcmVfY3R4IGluIGVhY2ggZnVuY3Rpb24uIFlvdSdyZSBsb2NraW5n IGFsbCBzdGF0ZSBoZXJlIGFmdGVyIGFsbC4uCgpBbHNvIHlvdSBzaG91bGQgdXNlIGRybV9hdG9t aWNfZ2V0Xypfc3RhdGUgaW5zdGVhZCBvZiBjYWxsaW5nIHRob3NlIGR1cGxpY2F0ZV9zdGF0ZSBm dW5jdGlvbnMgZGlyZWN0bHkuCgpPcCAxMS0wOC0xNSBvbSAxMzozNyBzY2hyZWVmIFRoaWVycnkg UmVkaW5nOgo+IEZyb206IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+Cj4KPiBU aGlzIGZ1bmN0aW9uIGNhbiBiZSB1c2VkIHRvIGR1cGxpY2F0ZSBhbiBhdG9taWMgc3RhdGUgb2Jq ZWN0LiBUaGlzIGlzCj4gdXNlZnVsIGZvciBleGFtcGxlIHRvIGltcGxlbWVudCBzdXNwZW5kL3Jl c3VtZSwgd2hlcmUgdGhlIHN0YXRlIGJlZm9yZQo+IHN1c3BlbmQgY2FuIGJlIHNhdmVkIGFuZCBy ZXN0b3JlZCB1cG9uIHJlc3VtZS4KPgo+IFNpZ25lZC1vZmYtYnk6IFRoaWVycnkgUmVkaW5nIDx0 cmVkaW5nQG52aWRpYS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hl bHBlci5jIHwgOTAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNs dWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oICAgICB8ICAyICsKPiAgMiBmaWxlcyBjaGFuZ2Vk LCA5MiBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9h dG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGlu ZGV4IGZkMDY1OTVjMmVlNS4uZjg0MjQ5OWNhNzllIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMKPiBAQCAtMjM1OCw2ICsyMzU4LDk2IEBAIGRybV9hdG9taWNfaGVscGVyX2Nv bm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikK PiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZHVwbGljYXRlX3N0 YXRlKTsKPiAgCj4gIC8qKgo+ICsgKiBkcm1fYXRvbWljX2hlbHBlcl9kdXBsaWNhdGVfc3RhdGUg LSBkdXBsaWNhdGUgYW4gYXRvbWljIHN0YXRlIG9iamVjdAo+ICsgKiBAZGV2OiBEUk0gZGV2aWNl Cj4gKyAqCj4gKyAqIE1ha2VzIGEgY29weSBvZiB0aGUgY3VycmVudCBhdG9taWMgc3RhdGUgYnkg bG9vcGluZyBvdmVyIGFsbCBvYmplY3RzIGFuZAo+ICsgKiBkdXBsaWNhdGluZyB0aGVpciByZXNw ZWN0aXZlIHN0YXRlcy4KPiArICoKPiArICogUmV0dXJuczogQSBwb2ludGVyIHRvIHRoZSBjb3B5 IG9mIHRoZSBhdG9taWMgc3RhdGUgb2JqZWN0IG9uIHN1Y2Nlc3Mgb3IgYW4KPiArICogRVJSX1BU UigpLWVuY29kZWQgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ICsgKi8KPiArc3RydWN0IGRybV9h dG9taWNfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2hlbHBlcl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0 IGRybV9kZXZpY2UgKmRldikKPiArewo+ICsJc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4 IGN0eDsKPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiArCXN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uOwo+ICsJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gKwlzdHJ1Y3Qg ZHJtX2NydGMgKmNydGM7Cj4gKwlpbnQgZXJyOwo+ICsKPiArCXN0YXRlID0gZHJtX2F0b21pY19z dGF0ZV9hbGxvYyhkZXYpOwo+ICsJaWYgKCFzdGF0ZSkKPiArCQlyZXR1cm4gRVJSX1BUUigtRU5P TUVNKTsKPiArCj4gKwlkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4gKwlzdGF0 ZS0+YWNxdWlyZV9jdHggPSAmY3R4Owo+ICsKPiArCWVyciA9IGRybV9tb2Rlc2V0X2xvY2soJmRl di0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCwgJmN0eCk7Cj4gKwlpZiAoZXJyIDwgMCkK PiArCQlnb3RvIGZyZWU7Cj4gKwo+ICsJZHJtX2Zvcl9lYWNoX2NydGMoY3J0YywgZGV2KSB7Cj4g KwkJdW5zaWduZWQgaW50IGluZGV4ID0gZHJtX2NydGNfaW5kZXgoY3J0Yyk7Cj4gKwkJc3RydWN0 IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ICsKPiArCQljcnRjX3N0YXRlID0gY3J0Yy0+ ZnVuY3MtPmF0b21pY19kdXBsaWNhdGVfc3RhdGUoY3J0Yyk7Cj4gKwkJaWYgKCFjcnRjX3N0YXRl KSB7Cj4gKwkJCWVyciA9IC1FTk9NRU07Cj4gKwkJCWdvdG8gdW5sb2NrOwo+ICsJCX0KPiArCj4g KwkJc3RhdGUtPmNydGNfc3RhdGVzW2luZGV4XSA9IGNydGNfc3RhdGU7Cj4gKwkJc3RhdGUtPmNy dGNzW2luZGV4XSA9IGNydGM7Cj4gKwkJY3J0Y19zdGF0ZS0+c3RhdGUgPSBzdGF0ZTsKPiArCX0K PiArCj4gKwlkcm1fZm9yX2VhY2hfcGxhbmUocGxhbmUsIGRldikgewo+ICsJCXVuc2lnbmVkIGlu dCBpbmRleCA9IGRybV9wbGFuZV9pbmRleChwbGFuZSk7Cj4gKwkJc3RydWN0IGRybV9wbGFuZV9z dGF0ZSAqcGxhbmVfc3RhdGU7Cj4gKwo+ICsJCXBsYW5lX3N0YXRlID0gcGxhbmUtPmZ1bmNzLT5h dG9taWNfZHVwbGljYXRlX3N0YXRlKHBsYW5lKTsKPiArCQlpZiAoIXBsYW5lX3N0YXRlKSB7Cj4g KwkJCWVyciA9IC1FTk9NRU07Cj4gKwkJCWdvdG8gdW5sb2NrOwo+ICsJCX0KPiArCj4gKwkJc3Rh dGUtPnBsYW5lX3N0YXRlc1tpbmRleF0gPSBwbGFuZV9zdGF0ZTsKPiArCQlzdGF0ZS0+cGxhbmVz W2luZGV4XSA9IHBsYW5lOwo+ICsJCXBsYW5lX3N0YXRlLT5zdGF0ZSA9IHN0YXRlOwo+ICsJfQo+ ICsKPiArCWRybV9mb3JfZWFjaF9jb25uZWN0b3IoY29ubiwgZGV2KSB7Cj4gKwkJdW5zaWduZWQg aW50IGluZGV4ID0gZHJtX2Nvbm5lY3Rvcl9pbmRleChjb25uKTsKPiArCQlzdHJ1Y3QgZHJtX2Nv bm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsKPiArCj4gKwkJY29ubl9zdGF0ZSA9IGNvbm4tPmZ1 bmNzLT5hdG9taWNfZHVwbGljYXRlX3N0YXRlKGNvbm4pOwo+ICsJCWlmICghY29ubl9zdGF0ZSkg ewo+ICsJCQllcnIgPSAtRU5PTUVNOwo+ICsJCQlnb3RvIHVubG9jazsKPiArCQl9Cj4gKwo+ICsJ CXN0YXRlLT5jb25uZWN0b3Jfc3RhdGVzW2luZGV4XSA9IGNvbm5fc3RhdGU7Cj4gKwkJc3RhdGUt PmNvbm5lY3RvcnNbaW5kZXhdID0gY29ubjsKPiArCQljb25uX3N0YXRlLT5zdGF0ZSA9IHN0YXRl Owo+ICsJfQo+ICsKPiArdW5sb2NrOgo+ICsJZHJtX21vZGVzZXRfZHJvcF9sb2NrcygmY3R4KTsK PiArZnJlZToKPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiArCj4gKwlpZiAo ZXJyIDwgMCkgewo+ICsJCWRybV9hdG9taWNfc3RhdGVfZnJlZShzdGF0ZSk7Cj4gKwkJc3RhdGUg PSBFUlJfUFRSKGVycik7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIHN0YXRlOwo+ICt9Cj4gK0VYUE9S VF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfZHVwbGljYXRlX3N0YXRlKTsKPiArCj4gKy8qKgo+ ICAgKiBfX2RybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kZXN0cm95X3N0YXRlIC0gcmVsZWFz ZSBjb25uZWN0b3Igc3RhdGUKPiAgICogQGNvbm5lY3RvcjogY29ubmVjdG9yIG9iamVjdAo+ICAg KiBAc3RhdGU6IGNvbm5lY3RvciBzdGF0ZSBvYmplY3QgdG8gcmVsZWFzZQo+IGRpZmYgLS1naXQg YS9pbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21p Y19oZWxwZXIuaAo+IGluZGV4IDRmZmU5ZGNhMDdjNC4uNWQyNzYxMjk5N2NlIDEwMDY0NAo+IC0t LSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgKPiArKysgYi9pbmNsdWRlL2RybS9k cm1fYXRvbWljX2hlbHBlci5oCj4gQEAgLTExOCw2ICsxMTgsOCBAQCBfX2RybV9hdG9taWNfaGVs cGVyX2Nvbm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvciwKPiAgCQkJCQkgICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqc3RhdGUpOwo+ICBz dHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqCj4gIGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rv cl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rvcik7Cj4gK3N0 cnVjdCBkcm1fYXRvbWljX3N0YXRlICoKPiArZHJtX2F0b21pY19oZWxwZXJfZHVwbGljYXRlX3N0 YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICB2b2lkCj4gIF9fZHJtX2F0b21pY19oZWxw ZXJfY29ubmVjdG9yX2Rlc3Ryb3lfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv ciwKPiAgCQkJCQkgICAgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKnN0YXRlKTsKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==