From: oliver+list@schinagl.nl (Olliver Schinagl) Date: Wed, 12 Aug 2015 16:57:27 +0200 Subject: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating. In-Reply-To: References: <55CB3D92.6040403@redhat.com> <55CB47D8.4010207@schinagl.nl> Message-ID: <55CB5ED7.40406@schinagl.nl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The thing is, I never saw the prints in my console (i assume that it prints on the console by default with earlyprintk/debug stuff enabled as per sunxi-usual)? P.S. what I do as a basic test, is on our very very minimal empty debian image (think < 150 mb) i do a apt-get build-essential that installs about 150mb worth of packages. Without these patches, everything works as before. All packages successfully installed. I can do more intense testing later, but I figured that this is pretty intense. Olliver On 12-08-15 15:37, Michal Suchanek wrote: > On 12 August 2015 at 15:19, Olliver Schinagl wrote: >> Hey, >> >> On 12-08-15 14:35, Hans de Goede wrote: >>> Hi, >>> >>> On 12-08-15 14:23, Michal Suchanek wrote: >>>> When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable >>>> automatic hardware controlled clock gating on the mmc interface. >>>> >>>> Signed-off-by: Michal Suchanek >>> >>> In general this looks good, but I wonder how intensively this has >>> been tested ? >> It doesn't matter actually, it took some time longer, but the mmc still >> craps out even with Michal's 3 patches. I'll revert hans's earlier patch >> again and do a bit more extensive testing. > Does the oclk switch timeout even after 750ms? > > In some earlier tests I tried to enable/disable the clock repeatedly > when it failed but it seemed to have little effect on the total time > it took to disable the clock in the end. > > Maybe it would be worh trying to set the timeout to some insanely long > value and test stability with that. I picked 750 as around twice the > maximum time it ever took on my board. > > Thanks > > Michal >