From: Eugene Shatokhin Subject: Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH Date: Tue, 1 Sep 2015 16:54:24 +0300 Message-ID: <55E5AE10.2030108@rosalab.ru> References: <55AD3A41.2040100@rosalab.ru> <1440447223-15945-1-git-send-email-eugene.shatokhin@rosalab.ru> <1440447223-15945-3-git-send-email-eugene.shatokhin@rosalab.ru> <87k2sk9zaf.fsf@nemi.mork.no> <55E01750.4010202@rosalab.ru> <87mvxbzta9.fsf@nemi.mork.no> <55E03B28.6050305@rosalab.ru> <87io7vzzdl.fsf@nemi.mork.no> <55E41557.1060803@rosalab.ru> <1441094336.3328.1.camel@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?Q?Bj=c3=b8rn_Mork?= , David Miller , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org To: Oliver Neukum Return-path: In-Reply-To: <1441094336.3328.1.camel@suse.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org 01.09.2015 10:58, Oliver Neukum =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Mon, 2015-08-31 at 11:50 +0300, Eugene Shatokhin wrote: >>> But I would have liked it much better if the code became simpler >> instead >>> of more complex. >> >> Me too, but I can see no other way here. The code is simpler without >> locking, indeed, but locking is needed to prevent the problems >> described >> earlier. > > On a practical note, will you resend the patch? Yes, I will do it shortly. Thanks for your help! Regards, Eugene