Received: from eggs.gnu.org ([2001:4830:134:3::10]:50578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXW9I-0000eD-9O for qemu-devel@nongnu.org; Thu, 03 Sep 2015 11:10:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXW9D-0000h3-Q8 for qemu-devel@nongnu.org; Thu, 03 Sep 2015 11:10:00 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:37378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXW9D-0000gr-KX for qemu-devel@nongnu.org; Thu, 03 Sep 2015 11:09:55 -0400 References: <1441239463-18981-1-git-send-email-rth@twiddle.net> <1441239463-18981-5-git-send-email-rth@twiddle.net> From: Bastian Koppelmann Message-ID: <55E862C0.5080803@mail.uni-paderborn.de> Date: Thu, 3 Sep 2015 17:09:52 +0200 MIME-Version: 1.0 In-Reply-To: <1441239463-18981-5-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/17] target-openrisc: Keep SR_F in a separate variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, proljc@gmail.com On 09/03/2015 02:17 AM, Richard Henderson wrote: > This avoids having to keep merging and extracting the flag from SR. > > Signed-off-by: Richard Henderson > --- > target-openrisc/cpu.h | 15 +++++- > target-openrisc/gdbstub.c | 4 +- > target-openrisc/interrupt.c | 2 +- > target-openrisc/interrupt_helper.c | 2 +- > target-openrisc/sys_helper.c | 5 +- > target-openrisc/translate.c | 96 +++++++++++++++----------------------- > 6 files changed, 56 insertions(+), 68 deletions(-) > > diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h > index 36c4f20..e91f2a9 100644 > --- a/target-openrisc/cpu.h > +++ b/target-openrisc/cpu.h > @@ -288,7 +288,8 @@ typedef struct CPUOpenRISCState { > target_ulong epcr; /* Exception PC register */ > target_ulong eear; /* Exception EA register */ > > - uint32_t sr; /* Supervisor register */ > + target_ulong sr_f; /* the SR_F bit */ A comment that states the expected value of sr_f would be nice. Other then that, Reviewed-by: Bastian Koppelmann