Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:41996 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932533AbbICPYZ (ORCPT ); Thu, 3 Sep 2015 11:24:25 -0400 Message-ID: <55E86624.4000403@roeck-us.net> Date: Thu, 03 Sep 2015 08:24:20 -0700 From: Guenter Roeck MIME-Version: 1.0 To: Luis de Bethencourt , linux-kernel@vger.kernel.org CC: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Javier Martinez Canillas Subject: Re: [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver References: <20150903110609.GA17390@goodgumbo.baconseed.org> In-Reply-To: <20150903110609.GA17390@goodgumbo.baconseed.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 09/03/2015 04:06 AM, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt Reviewed-by: Guenter Roeck > --- > drivers/watchdog/moxart_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c > index 2789da2..60b0605 100644 > --- a/drivers/watchdog/moxart_wdt.c > +++ b/drivers/watchdog/moxart_wdt.c > @@ -168,6 +168,7 @@ static const struct of_device_id moxart_watchdog_match[] = { > { .compatible = "moxa,moxart-watchdog" }, > { }, > }; > +MODULE_DEVICE_TABLE(of, moxart_watchdog_match); > > static struct platform_driver moxart_wdt_driver = { > .probe = moxart_wdt_probe, >