Received: from eggs.gnu.org ([2001:4830:134:3::10]:54429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXqnA-00050u-Vv for qemu-devel@nongnu.org; Fri, 04 Sep 2015 09:12:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXqn6-0007D9-TN for qemu-devel@nongnu.org; Fri, 04 Sep 2015 09:12:32 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:59778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXqn6-0007D3-Mu for qemu-devel@nongnu.org; Fri, 04 Sep 2015 09:12:28 -0400 References: <1441239463-18981-1-git-send-email-rth@twiddle.net> <1441239463-18981-3-git-send-email-rth@twiddle.net> <55E85633.3070909@mail.uni-paderborn.de> <55E85CDC.7040003@twiddle.net> From: Bastian Koppelmann Message-ID: <55E998B8.5050707@mail.uni-paderborn.de> Date: Fri, 4 Sep 2015 15:12:24 +0200 MIME-Version: 1.0 In-Reply-To: <55E85CDC.7040003@twiddle.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/17] target-openrisc: Streamline arithmetic and OVE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, proljc@gmail.com On 09/03/2015 04:44 PM, Richard Henderson wrote: > That's patch 7/17. ;-) Woops , I just realized ;-) > R0 is not an *architectural* zero. It's a software convention. The > spec is fairly clear on this point. > > I agree that there ought to be some special-casing of the software > convention, but that should require a TB flag to verify the convention > is followed. But even then I would not bother retaining the special > case here in multiply. I would only use it in the "move" and constant > formation types of pseudo instructions (or, ori, etc). That sounds reasonable and is clearly for another patch, so Reviewed-by: Bastian Koppelmann Cheers, Bastian