Received: from eggs.gnu.org ([2001:4830:134:3::10]:52193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbqC6-0008HA-Rv for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:22:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbpuK-00044o-Pj for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:04:30 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:45215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbpuK-00044T-IV for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:04:24 -0400 References: <1441239463-18981-1-git-send-email-rth@twiddle.net> <1441239463-18981-18-git-send-email-rth@twiddle.net> From: Bastian Koppelmann Message-ID: <55F8174A.5030505@mail.uni-paderborn.de> Date: Tue, 15 Sep 2015 15:04:10 +0200 MIME-Version: 1.0 In-Reply-To: <1441239463-18981-18-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/17] target-openrisc: Implement lwa, swa List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, proljc@gmail.com On 09/03/2015 02:17 AM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/main.c | 45 ++++++++++++++++++++++++ > target-openrisc/cpu.c | 1 + > target-openrisc/cpu.h | 9 +++++ > target-openrisc/interrupt.c | 1 + > target-openrisc/interrupt_helper.c | 1 + > target-openrisc/mmu.c | 1 + > target-openrisc/translate.c | 70 ++++++++++++++++++++++++++++++++++++++ > 7 files changed, 128 insertions(+) This looks good to me. However I don't feel confident enough to give a rb. Cheers, Bastian