From: Konstantin Khlebnikov Subject: Re: [PATCH RFC] pidns: introduce syscall getvpid Date: Wed, 16 Sep 2015 10:37:33 +0300 Message-ID: <55F91C3D.1040209@yandex-team.ru> References: <20150915120924.14818.49490.stgit@buzz> <87h9mvg3kw.fsf@x220.int.ebiederm.org> <55F832D2.1070605@yandex-team.ru> <20150915151729.GA144242@dakara> <20150915174143.GE4699@ubuntumail> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150915174143.GE4699@ubuntumail> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Serge Hallyn , =?UTF-8?Q?St=c3=a9phane_Graber?= Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Oleg Nesterov , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Eric W. Biederman" , Andrew Morton , Linus Torvalds List-Id: linux-api@vger.kernel.org On 15.09.2015 20:41, Serge Hallyn wrote: > Quoting St=E9phane Graber (stgraber-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org): >> On Tue, Sep 15, 2015 at 06:01:38PM +0300, Konstantin Khlebnikov wrot= e: >>> On 15.09.2015 17:27, Eric W. Biederman wrote: >>>> Konstantin Khlebnikov writes: >>>> >>>>> pid_t getvpid(pid_t pid, pid_t source, pid_t target); >>>>> >>>>> This syscall converts pid from one pid-ns into pid in another pid= -ns: >>>>> it takes @pid in namespace of @source task (zero for current) and >>>>> returns related pid in namespace of @target task (zero for curren= t too). >>>>> If pid is unreachable from target pid-ns then it returns zero. >>>> >>>> This interface as presented is inherently racy. It would be bette= r >>>> if source and target were file descriptors referring to the namesp= aces >>>> you wish to translate between. >>> >>> Yep, it's racy. As well as any operation with non-child pids. >>> With file descriptors for source/target result will be racy anyway. >>> >>>> >>>>> Such conversion is required for interaction between processes fro= m >>>>> different pid-namespaces. For example when system service talks w= ith >>>>> client from isolated container via socket about task in container= : >>>> >>>> Sockets are already supported. At least the metadata of sockets i= s. >>>> >>>> Maybe we need this but I am not convinced of it's utility. >>>> >>>> What are you trying to do that motivates this? >>> >>> I'm working on hierarchical container management system which >>> allows to create and control nested sub-containers from containers >>> ( https://github.com/yandex/porto ). Main server works in host and >>> have to interact with all levels of nested namespaces. This syscall >>> makes some operations much easier: server must remember only pid in >>> host pid namespace and convert it into right vpid on demand. >> >> Note that as Eric said earlier, sending a PID inside a ucred through= a >> unix socket will have the pid translated. >> >> So while your solution certainly should be faster, you can already a= chieve >> what you want today by doing: >> >> =3D=3D Translate PID in container to PID in host >> - open a socket >> - setns to container's pidns >> - send ucred from that container containing the requested containe= r PID >> - host sees the host PID >> >> =3D=3D Translate PID on host to PID in container >> - open a socket >> - setns to container's pidns >> - send ucred from the host containing the request host PID >> (send will fail if the host PID isn't part of that container) >> - container sees the container PID > > In addition, since commit e4bc332451 : /proc/PID/status: show all set= s of pid according to ns > we now also have 'NSpid' etc in /proc/$$/status. > As I see this works perfectly only for converting host pid into virtual= =2E Backward conversion is troublesome: we have to scan all pids in host procfs and somehow filter tasks from container and its sub-pid-ns. Or I am missing something trivial? --=20 Konstantin