Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED657C433DF for ; Tue, 14 Jul 2020 09:51:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B71A720EDD for ; Tue, 14 Jul 2020 09:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z7OhmTn3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="XkzOnpJy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B71A720EDD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IkfWib9uzaUQWcLe5pyFqCAopU0+jGkqxHNI9advAYY=; b=Z7OhmTn3bVIU8hDD6uUuGtuBG FQAnnGaOB+gHPA7hFfCoWnXCZAo6aDZG8qnTbm3zfKwXY0788W7jaj7YDExljoH6CS9IqkxOlwy5d Un6U+s58gNMA0SkvuktSwUbWQ4JpLAxpvh+RIy1j0tqtfLKit+FgouBjPARJmcUusLRVHO1mD6kGR jhsKCUXi8bU92yub9zKaMeefHcJ07jZ06YWvd70DU7tqYhSwq9juuteR1TdXWr7uaSJz75gDS8gkU qtE8oPloYotCyLUXB+kcz9/IU09XeM1mEvixfkbFRvs502XAvYSWwPVUDGbXRNnwiIrXCcP1ijujK qw0RskHWQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvHZu-0008RB-4a; Tue, 14 Jul 2020 09:50:22 +0000 Received: from mout.web.de ([212.227.17.12]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvHZj-0008OB-O4 for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 09:50:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1594720209; bh=YpY+ooN0uIuD8Gb68P94HhNWqgFpGAGQxrUygDp5Wuw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=XkzOnpJy7uFtxBzE7+VYjVgcdl61ogD9XpFvS9tMW5SGbnXNleGT7kitYuhks/esP 7IAW3JSXVNxH7Qa6U+q7vEzqHKTiXuMz0VsFGuIonFvnM5hQiHh9/TxwNU/6FiqO/5 Rq3Xn4h/taEstf3Uh4lWZkdkS1oxlsn5ge24A3Hk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.43.108] ([89.204.139.116]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M43GU-1jvHZh1sLQ-000W1j; Tue, 14 Jul 2020 11:50:09 +0200 Subject: Re: [PATCH v2 2/2] ARM: dts: imx6qdl-sabresd: Pass reset-assert-us To: Fabio Estevam , shawnguo@kernel.org References: <20200713130416.20040-1-festevam@gmail.com> <20200713130416.20040-2-festevam@gmail.com> From: Soeren Moch Message-ID: <55e97d7b-133e-9069-56bd-7aa38445003d@web.de> Date: Tue, 14 Jul 2020 11:50:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200713130416.20040-2-festevam@gmail.com> Content-Language: en-GB X-Provags-ID: V03:K1:c6HA1YIelv0ZDVFW6X1sm1H7N7HghyZoE8TnU8mJbWhRGvISVU4 Go2OaY/E6r6A+W8tWkYNfV9yjjsBq8INUNZ6+4/4r9CS5Jp25e/9OvOViBGds2aqg+9UBJh Mv1JGjdXqhks+/eB+75EwgWs98PweY/xvxh+XRiM8xpEHpJQOdNeG1LAA5u2Gfj3Z5C8/fJ daYfR+CGq7ZYYcuUAI9Fw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Nm13Ov6d1G8=:yteClILdJNxJdPzqOgVNk1 xkQ7apTg3A8OitSogCWti1YcPwCJQWXMKJTSZZvMwpkF1a5ZtCpTHojM/kslY6H2eVbgSMIxA 2kmwgHGhuSeBaU5OPH+STnuYELXUBizTwRol/H0BA24Pt2ayA/6o0UAYp4zThI0vk0PQJyDeN GqwepgXYQOQxL9vCYo+7rv256NGUwJP4wsfECECLHaColnm7SZYWOxu/8KIX97VJXjV3dVdzJ TKlEtdsjWI8ekyV2jdH93M4zpa00PyFOxwfYQBK/FKarjytiNZ3LmDDOAg2GuHvdXpMcXQub/ IvkaHnpDYSaMoi6OxmA2UldjCSgUkED5aG7iIIOzjl89dE0Mz6BnbrVcippRqF8ftrPjyc4JL ZnFiPF1GD4vdttcUY6jB+Stx76V2qk2Rp9uVkVRMRXuV1yinvBjBYjUgd6dpl34Li6zkMFGYx 7uDC9CxzVQP/hY7xOxuNnzuL6D+nxKzt+T6RRdKyYYfk+Xg7j9z28DFnZlw1AzMHuZnefv5nB 3AF+XLaSaCkm2m00hjgL9WEfe2eAP+gNhIh6esbOiC0g6ZFEBUXl45ituUhzYEBSBUdKQTNIQ ARal7KzJJonezkZS5OMEYtIxLWNX/GeYWpmmB4ExJCDFrP+na5Yp5kZHJpuHZKA6d1bxmLuqc 0YUWlMO+70ug+wDWWSoh2PfkHwKrIZJ8HxKVF7uDsbLPH+/rykGP9DEkKTcqRA6bTT840EyDb ROU8phuwQ0TdfLzJIBEp9F3VVKl2NooUuOgNRtfGpPtptOp2szpknBqB+2C3/ujlE+juknUg0 +lwoyrVvGyFm9bcDerhjFc54a2hxEVGtQViTgu00L7L0EUT08LQHfNh8GZhJ1OReNM9RGQ/jt cqtOUvTfgaSeAXmgLOnqkxUNGS3ORAkFCiT57/XH91OKzkD+TZ1F/u7/CtZs3lkSwm5ddIZni +yCpAV0tAtt9Dc6JojlTfcZHbWLMpJqiniduOooYRW+D41nWpVPBb4Gc1kMxEaX8EpkCPZJv0 mIjQoRDdkPOp3wLjB0tUbpyxckA/BnLyrX0itna5WkDRcimneUr3CFq8O7tgG0VE/EV6oIYch Ux+nVu+ZWcB3BVdOP7DtO3QK4weaCdTAVl8xwv3NYX38UV7oHdwQsOuymBbCZcydXosYg9GTg z6bf+7odEkTwqX8UHcm1XGtxfXuQo3I9gAjRpc29S0u/uhxmpJazkJmuVc3eIvWrOsHLBqNdR A8iCsEQa/cVL++KIN X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_055012_058123_F273664E X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13.07.20 15:04, Fabio Estevam wrote: > According to the AR8031 datasheet: > > "When using crystal, clock is generated internally after the power is > stable. In order to get reliable power-on-reset, it is recommended to > keep asserting the reset low signal long enough (10 ms) to ensure the > clock is stable and clock-to-reset (1 ms) requirement is satisfied." > > Pass the 'reset-assert-us' property to describe such requirement. > > While at it, use the 'reset-gpios' property inside the the mdio > node instead of the deprecated usage of 'phy-reset-gpios'. > > Signed-off-by: Fabio Estevam Reviewed-by: Soeren Moch Thanks, Soeren > --- > Changes since v1: > - Use reset-gpios and reset-assert-us inside the mdio node > instead of the deprecated usage of phy-reset-gpios (Soeren) > > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index 6524ad4b0010..5597d45fffda 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @@ -204,7 +204,6 @@ > pinctrl-0 = <&pinctrl_enet>; > phy-mode = "rgmii-id"; > phy-handle = <&phy>; > - phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > fsl,magic-packet; > status = "okay"; > > @@ -215,6 +214,8 @@ > phy: ethernet-phy@1 { > reg = <1>; > qca,clk-out-frequency = <125000000>; > + reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > + reset-assert-us = <10000>; > }; > }; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel