Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64B45C47258 for ; Wed, 17 Jan 2024 15:53:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA2D310E6B7; Wed, 17 Jan 2024 15:53:17 +0000 (UTC) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 540EE10E6B7 for ; Wed, 17 Jan 2024 15:53:14 +0000 (UTC) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 40HFqhek107121; Wed, 17 Jan 2024 09:52:44 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1705506764; bh=UqoXHpuOsyXayN31wfG4/f1gx1ZHV/XtpeqO3uEEUxI=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=PcSv0otRf22cpnWL4ex8dgpTo4kYPE2YfM2FC7uA12j/9tyFYkEgZ2AhY9W2/eqIL UCcCKSNc2rAQMq34hF8aMVsEK2gtD8n3zgq1B2X+uumQ7rbozLTXHpMAbIth4PU623 ZP/avpnMlwdRxFKiL0uRf9F+iQpxHCSIF8/AviO8= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 40HFqh7o004410 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 17 Jan 2024 09:52:43 -0600 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 17 Jan 2024 09:52:43 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 17 Jan 2024 09:52:43 -0600 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 40HFqgSs087030; Wed, 17 Jan 2024 09:52:42 -0600 Message-ID: <55efd488-c6a0-4dca-baea-1fa93d13dd17@ti.com> Date: Wed, 17 Jan 2024 09:52:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/11] ARM: dts: DRA7xx: Add device tree entry for SGX GPU To: Tony Lindgren References: <20240109171950.31010-1-afd@ti.com> <20240109171950.31010-9-afd@ti.com> <20240110082924.GA5185@atomide.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20240110082924.GA5185@atomide.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vignesh Raghavendra , "H . Nikolaus Schaller" , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , Krzysztof Kozlowski , Ivaylo Dimitrov , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Conor Dooley , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Maxime Ripard , Matt Coster , Rob Herring , linux-omap@vger.kernel.org, Adam Ford , linux-arm-kernel@lists.infradead.org, Tero Kristo , linux-kernel@vger.kernel.org, Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/10/24 2:29 AM, Tony Lindgren wrote: > * Andrew Davis [240109 17:20]: >> --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi >> +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi >> @@ -850,12 +850,19 @@ target-module@56000000 { >> ; >> ti,sysc-sidle = , >> , >> - ; >> + , >> + ; > > You probably checked this already.. But just in case, can you please > confirm this is intentional. The documentation lists the smart wakeup > capability bit as reserved for dra7, maybe the documentation is wrong. > It was an intentional change, although I'm not sure it is correct :) This is how we had it in our "evil vendor tree" for years (back when it was hwmod based), so when converting these nodes to use "ti,sysc" I noticed this bit was set, but as you point out the documentation disagrees. I'd rather go with what has worked before, but it doesn't seem to break anything either way, so we could also break this change out into its own patch if you would prefer. Andrew > Regards, > > Tony >