Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6AC4C433F5 for ; Sat, 29 Jan 2022 02:45:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6074C8210D; Sat, 29 Jan 2022 03:45:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EDZ+rJ2A"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C5418367D; Sat, 29 Jan 2022 03:45:06 +0100 (CET) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4662081112 for ; Sat, 29 Jan 2022 03:45:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.bossman075@gmail.com Received: by mail-qt1-x82e.google.com with SMTP id v5so6829479qto.7 for ; Fri, 28 Jan 2022 18:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZIyXY4RA9hwrTe0HaEum+qdLWUCjAEwD/7PuEHO3WjQ=; b=EDZ+rJ2A2W0/cZoWpqpm4VYy+LRDnD4euXXAzB4Rw1pqe6svaiqXjOWKzwjwndolJr JXZ9B8BqOqBMyW7ugamZu/xRFhErvNzy+4xeOblA74uWgPFq7rfP/WYYSSa2gxIZ7vz8 GjarViJ8OZdxxMX+6QHkE1O+yBYsPZdwivacaipuXiNKMgNYa+a8Pl6Fb585OE8O1q7h 3i5rfNnWOWw/7XAmfEZ2ByIK0zxmPLuLz+xz9cDkWJqslIDfi2hhA/jldDDHXXYVaKOI 2O69pPgICiJnHf1680biYZzG9HtJukRlC+ihvJR5Yd5Krq49diKan0xrjZAbK2ggQr/t N/Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZIyXY4RA9hwrTe0HaEum+qdLWUCjAEwD/7PuEHO3WjQ=; b=p3DUdoZJrU01+5vPmN6BPoAp5uCOaKl6zamupbk3BNxE/VA+fM5SkptCemMLuuidDN rXpOC3DxyY2SEe6v/1KiMuPnFkAE5oUGtxVRITBTojlzxfZIoeKfrGQSvuajdvlIwtNJ WvA1LM1MTvafgwx2AtbxlYCAD2/X9syEcAwOi8pGhWb14cpxHoHGcwKKr0hK4iDehwgl kRtOX+dlMDTNWe2d6fi3xGiqAR38VhE8+PyQ6MVMYJ7V1N7uvFxD9EhJx5rts50eCNEZ CKjtL56VgKEmgd/2vob4A0mQRsAITjsIAPH0HGPYODsJooSP3SD+sKw47VRb26OHa4Ma MMdQ== X-Gm-Message-State: AOAM531YCChb4RWjpaS1ENUfxc7lGnouBjFqNPtrmOVpTI6m3UdntTgM a1kMrmC8atd4VXML1wVTg+k= X-Google-Smtp-Source: ABdhPJx+5UsM29zE1VgdDnosVoKr1kuqd/GQq559PMhFMouLlzzXdEqinQXMi/2QUe0qNFJYp0FsjA== X-Received: by 2002:a05:622a:1dc3:: with SMTP id bn3mr8385558qtb.482.1643424299917; Fri, 28 Jan 2022 18:44:59 -0800 (PST) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id a9sm4154540qtb.50.2022.01.28.18.44.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 18:44:59 -0800 (PST) Message-ID: <55fb095d-bc66-271a-6cda-ccebea96b1f3@gmail.com> Date: Fri, 28 Jan 2022 21:44:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 00/12] Add support for SUNIV and F1C100s. Content-Language: en-US To: Andre Przywara Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, hdegoede@redhat.com, sjg@chromium.org, icenowy@aosc.io, marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com, tharvey@gateworks.com, christianshewitt@gmail.com, pbrobinson@gmail.com, jernej.skrabec@gmail.com, hs@denx.de, samuel@sholland.org, arnaud.ferraris@gmail.com, giulio.benetti@benettiengineering.com, thirtythreeforty@gmail.com References: <20220126135329.2997430-1-Mr.Bossman075@gmail.com> <20220129024034.78c2f30a@slackpad.fritz.box> From: Jesse Taube In-Reply-To: <20220129024034.78c2f30a@slackpad.fritz.box> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 1/28/22 21:40, Andre Przywara wrote: > On Wed, 26 Jan 2022 08:53:17 -0500 > Jesse Taube wrote: > > Hi Jesse, > >> This patch set aims to add support for the SUNIV and F1C100s. >> Support has been in linux for a while now, but not in u-boot. >> >> This patchset contains: >> - CPU specific initialization code >> - SUNIV dram driver >> - SUNIV clock driver adaption >> - SUNIV gpio driver adaption >> - SUNIV uart driver adaption >> - F1C100s basic support >> >> The SUNIV seems to be similar to sun6i and sun4i, so we use code from >> both platforms. We also add suniv to the cpu dircetory as it uses arm926ejs. >> >> NOTE: To work this will need patchset "sunxi: remove lowlevel_init". > > So I think I am done with reviewing this version. Please send an > updated version. If there are smaller issues left, I will probably just > fix them up while committing. > > Thanks for your good and prompt work on this! No worries I'm happy to do it an i think its fun. And if i wasn't doing this i would be playing video games. And I didn't convince my school to let me graduate early to play video games :). > Cheers, > Andre > >> >> Icenowy Zheng (11): >> arm: arm926ej-s: start.S: port save_boot_params support from armv7 >> code >> arm: arm926ej-s: Add sunxi code >> dt-bindings: clock: Add initial suniv headers >> dt-bindings: reset: Add initial suniv headers >> ARM: sunxi: Add clock and uart to sunxi headers >> sunxi: Add F1C100s DRAM initial support >> sunxi: board: Add support for SUNIV >> configs: sunxi: Add common SUNIV header >> mach-sunxi: Add support for SUNIV architecture >> ARM: dts: suniv: Add device tree files for F1C100s >> configs: sunxi: Add support for Lichee Pi Nano >> >> Jesse Taube (1): >> mach-sunxi: Move timer code to mach folder >> >> arch/arm/cpu/arm926ejs/Makefile | 1 + >> arch/arm/cpu/arm926ejs/start.S | 19 + >> arch/arm/cpu/arm926ejs/sunxi/Makefile | 5 + >> arch/arm/cpu/arm926ejs/sunxi/config.mk | 6 + >> arch/arm/cpu/arm926ejs/sunxi/fel_utils.S | 33 ++ >> arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds | 48 ++ >> arch/arm/dts/Makefile | 2 + >> arch/arm/dts/suniv-f1c100s-licheepi-nano.dts | 29 ++ >> arch/arm/dts/suniv-f1c100s.dtsi | 6 + >> arch/arm/dts/suniv.dtsi | 160 +++++++ >> arch/arm/include/asm/arch-sunxi/clock.h | 2 +- >> arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 13 + >> arch/arm/include/asm/arch-sunxi/cpu_sun4i.h | 6 + >> arch/arm/include/asm/arch-sunxi/dram.h | 2 + >> arch/arm/include/asm/arch-sunxi/dram_suniv.h | 46 ++ >> arch/arm/include/asm/arch-sunxi/gpio.h | 1 + >> arch/arm/mach-sunxi/Kconfig | 16 +- >> arch/arm/mach-sunxi/Makefile | 5 + >> arch/arm/mach-sunxi/board.c | 28 +- >> arch/arm/mach-sunxi/clock.c | 3 +- >> arch/arm/mach-sunxi/clock_sun6i.c | 46 +- >> arch/arm/mach-sunxi/cpu_info.c | 2 + >> arch/arm/mach-sunxi/dram_helpers.c | 4 + >> arch/arm/mach-sunxi/dram_suniv.c | 420 ++++++++++++++++++ >> .../{cpu/armv7/sunxi => mach-sunxi}/timer.c | 7 +- >> board/sunxi/board.c | 4 +- >> configs/licheepi_nano_defconfig | 15 + >> include/configs/suniv.h | 14 + >> include/configs/sunxi-common.h | 59 ++- >> include/dt-bindings/clock/suniv-ccu.h | 69 +++ >> include/dt-bindings/reset/suniv-ccu.h | 37 ++ >> 31 files changed, 1080 insertions(+), 28 deletions(-) >> create mode 100644 arch/arm/cpu/arm926ejs/sunxi/Makefile >> create mode 100644 arch/arm/cpu/arm926ejs/sunxi/config.mk >> create mode 100644 arch/arm/cpu/arm926ejs/sunxi/fel_utils.S >> create mode 100644 arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds >> create mode 100644 arch/arm/dts/suniv-f1c100s-licheepi-nano.dts >> create mode 100644 arch/arm/dts/suniv-f1c100s.dtsi >> create mode 100644 arch/arm/dts/suniv.dtsi >> create mode 100644 arch/arm/include/asm/arch-sunxi/dram_suniv.h >> create mode 100644 arch/arm/mach-sunxi/dram_suniv.c >> rename arch/arm/{cpu/armv7/sunxi => mach-sunxi}/timer.c (97%) >> create mode 100644 configs/licheepi_nano_defconfig >> create mode 100644 include/configs/suniv.h >> create mode 100644 include/dt-bindings/clock/suniv-ccu.h >> create mode 100644 include/dt-bindings/reset/suniv-ccu.h >> >