From: "cron2 (Code Review)" Date: Thu, 31 Jul 2025 15:43:41 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <55fdfc7564e443c5c391544b5c77fdcb8586f755-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Omj5rdTwiAg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix wrong byte order of --dns server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa , plaisthos , flichtenheld Cc: openvpn-devel --Omj5rdTwiAg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1125?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Fix wrong byte order of --dns server ...................................................................... Fix wrong byte order of --dns server We already fixed it in commit 82fd89a04f, but the fix got lost in 2dfc4f8. tuntap_options require host byte order, and we store dns servers in struct dns_server in network byte order, what we got from getaddrinfo(). Fix (again) by converting to the host byte order. Change-Id: I37ca672f05e9d77ec586fa28dadc6dc752e574fb Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20250731152912.21826-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 460.html Signed-off-by: Gert Doering --- M src/openvpn/options.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/25/1125/2 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 3ceada0..ff9addd 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3573,7 +3573,7 @@ { if (s->addr[i].family =3D=3D AF_INET && tt->dns_len + 1 < = N_DHCP_ADDR) { - tt->dns[tt->dns_len++] =3D s->addr[i].in.a4.s_addr; + tt->dns[tt->dns_len++] =3D ntohl(s->addr[i].in.a4.s_ad= dr); } else if (tt->dns6_len + 1 < N_DHCP_ADDR) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1125?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I37ca672f05e9d77ec586fa28dadc6dc752e574fb Gerrit-Change-Number: 1125 Gerrit-PatchSet: 2 Gerrit-Owner: stipa Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --Omj5rdTwiAg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by stipa.

View Change

The following approvals got outdated an= d were removed: Code-Review+2 by cron2

Fix wrong byte order of --dns server

We alrea= dy fixed it in commit 82fd89a04f, but
the fix got lost in 2dfc4f8.
tuntap_options require host byte order, and we store
dns servers in st= ruct dns_server in network byte order,
what we got from getaddrinfo().
Fix (again) by converting to the host byte order.

Change-Id: I= 37ca672f05e9d77ec586fa28dadc6dc752e574fb
Signed-off-by: Lev Stipakov <= ;lev@...515...>
Acked-by: Gert Doering <gert@...1296...>
Mes= sage-Id: <20250731152912.21826-1-gert@...1296...>
URL: https://www= .mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32460.html
Sign= ed-off-by: Gert Doering <gert@...1296...>
---
M src/openvpn/opt= ions.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull =
ssh://gerrit.openvpn.net:29418/openvpn refs/changes/25/1125/2
diff =
--git a/src/openvpn/options.c b/src/openvpn/options.c
index= 3ceada0..ff9addd 100644
--- a/src/openvpn/options.c=
+++ b/src/openvpn/options.c
@@ -3573,7 +3573,7 @@=
{
if (s->= addr[i].family =3D=3D AF_INET && tt->dns_len + 1 < N_DHCP_ADD= R)
{
- tt->dns[tt->dns_len++] =3D s->= addr[i].in.a4.s_addr;
+ tt->dns[tt->dns_len++] =3D ntohl(s->addr[i].= in.a4.s_addr);
}
= else if (tt->dns6_len + 1 < N_DHCP_ADDR)
= {

To view, visit change 1125= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37ca672f05e9d77ec586fa28dad= c6dc752e574fb
Gerrit-Change-Number: 1125
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--Omj5rdTwiAg=--