From: "cron2 (Code Review)" Date: Thu, 31 Jul 2025 15:43:43 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <55fdfc7564e443c5c391544b5c77fdcb8586f755-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="fCjkoCUVBTs="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix wrong byte order of --dns server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa Cc: plaisthos , flichtenheld , openvpn-devel --fCjkoCUVBTs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/11= 25?usp=3Demail ) Change subject: Fix wrong byte order of --dns server ...................................................................... Fix wrong byte order of --dns server We already fixed it in commit 82fd89a04f, but the fix got lost in 2dfc4f8. tuntap_options require host byte order, and we store dns servers in struct dns_server in network byte order, what we got from getaddrinfo(). Fix (again) by converting to the host byte order. Change-Id: I37ca672f05e9d77ec586fa28dadc6dc752e574fb Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20250731152912.21826-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 460.html Signed-off-by: Gert Doering --- M src/openvpn/options.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 3ceada0..ff9addd 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3573,7 +3573,7 @@ { if (s->addr[i].family =3D=3D AF_INET && tt->dns_len + 1 < = N_DHCP_ADDR) { - tt->dns[tt->dns_len++] =3D s->addr[i].in.a4.s_addr; + tt->dns[tt->dns_len++] =3D ntohl(s->addr[i].in.a4.s_ad= dr); } else if (tt->dns6_len + 1 < N_DHCP_ADDR) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1125?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I37ca672f05e9d77ec586fa28dadc6dc752e574fb Gerrit-Change-Number: 1125 Gerrit-PatchSet: 2 Gerrit-Owner: stipa Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --fCjkoCUVBTs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

Fix wrong byte order of --dns server

W= e already fixed it in commit 82fd89a04f, but
the fix got lost in 2dfc4f8= .

tuntap_options require host byte order, and we store
dns server= s in struct dns_server in network byte order,
what we got from getaddrin= fo().

Fix (again) by converting to the host byte order.

Chang= e-Id: I37ca672f05e9d77ec586fa28dadc6dc752e574fb
Signed-off-by: Lev Stipa= kov <lev@...515...>
Acked-by: Gert Doering <gert@...1296...>=
Message-Id: <20250731152912.21826-1-gert@...1296...>
URL: http= s://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32460.html<= br>Signed-off-by: Gert Doering <gert@...1296...>
---
M src/open= vpn/options.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 3ceada0..ff9addd 100644
--- a/src/openvpn/options.= c
+++ b/src/openvpn/options.c
@@ -3573,7 +3= 573,7 @@
{
if= (s->addr[i].family =3D=3D AF_INET && tt->dns_len + 1 < N_= DHCP_ADDR)
{
- tt->dns[tt->dns_len++] = =3D s->addr[i].in.a4.s_addr;
+ tt->dns[tt->dns_len++] =3D ntohl(s-&g= t;addr[i].in.a4.s_addr);
}
else if (tt->dns6_len + 1 < N_DHCP_ADDR)
= {

To view, visit= change = 1125. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37ca672f05e9d77ec586fa28dad= c6dc752e574fb
Gerrit-Change-Number: 1125
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--fCjkoCUVBTs=--