Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8EF410EB for ; Mon, 8 Jan 2024 03:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aKG9/LaS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704686141; x=1736222141; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=GBU0//KR2OTraJPkKfZU449iaYjYO92iKeN/GyrwWQM=; b=aKG9/LaS09xkPIx8/Fv5c2TM3W/VzseRXr1/ZRYm+1R49rJobKZ/g6vK PagSl5YaXsMxZaryjawpxR+2ZjLpwcULCcyUonVyNNNmJCZxaYwJb4PEN c8bKLG9Za6IuXLIF361KwXhZFnvkbMXQR8uLxl2eGU+K9qoz4Gltfbyh8 hK50p2AjxwSlQrO8/x1auJXM7WitqA5pW1ohcBINyk8xDEbxGegyB8cW4 MnWUC9GW8gwJLrWCx910yj6NO9iyM8GeNEfP9z2szKPJQgTparoniQyYb pHbMAezRDCh9TnneHSrQBjkq6Piex/yo8Kg+fFS0eHOOCQKTCsJm70Rxb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="19290157" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="19290157" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 19:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="757497873" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="757497873" Received: from ipu5-build.bj.intel.com (HELO [10.238.232.136]) ([10.238.232.136]) by orsmga006.jf.intel.com with ESMTP; 07 Jan 2024 19:55:37 -0800 Subject: Re: [PATCH v2 14/15] Documentation: add Intel IPU6 ISYS driver admin-guide doc To: Sakari Ailus , bingbu.cao@intel.com Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, andriy.shevchenko@linux.intel.com, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, andreaskleist@gmail.com, claus.stovgaard@gmail.com, tfiga@chromium.org, senozhatsky@chromium.org, tomi.valkeinen@ideasonboard.com, tian.shu.qiu@intel.com, hongju.wang@intel.com References: <20231024112924.3934228-1-bingbu.cao@intel.com> <20231024112924.3934228-15-bingbu.cao@intel.com> From: Bingbu Cao Message-ID: <5637c237-f939-3edc-4f45-b89f3dc241dc@linux.intel.com> Date: Mon, 8 Jan 2024 11:51:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sakari, On 10/25/23 8:15 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Tue, Oct 24, 2023 at 07:29:23PM +0800, bingbu.cao@intel.com wrote: >> From: Bingbu Cao >> >> This document mainly describe the functionality of IPU6 and >> IPU6 isys driver, and gives an example that how user can do >> imaging capture with tools. >> >> Signed-off-by: Bingbu Cao >> --- >> Documentation/admin-guide/media/ipu6-isys.rst | 159 +++ >> .../admin-guide/media/ipu6_isys_graph.svg | 338 +++++ >> .../admin-guide/media/ipu6_isys_multi.svg | 1124 +++++++++++++++++ >> .../admin-guide/media/v4l-drivers.rst | 1 + >> 4 files changed, 1622 insertions(+) >> create mode 100644 Documentation/admin-guide/media/ipu6-isys.rst >> create mode 100644 Documentation/admin-guide/media/ipu6_isys_graph.svg >> create mode 100644 Documentation/admin-guide/media/ipu6_isys_multi.svg >> >> diff --git a/Documentation/admin-guide/media/ipu6-isys.rst b/Documentation/admin-guide/media/ipu6-isys.rst >> new file mode 100644 >> index 000000000000..fb4d355e1522 >> --- /dev/null >> +++ b/Documentation/admin-guide/media/ipu6-isys.rst >> @@ -0,0 +1,159 @@ >> +.. SPDX-License-Identifier: GPL-2.0 >> + >> +.. include:: >> + >> +=============================================================== >> +Intel Image Processing Unit 6 (IPU6) Input System driver >> +=============================================================== > > Too many '='s. > >> + >> +Copyright |copy| 2023 Intel Corporation >> + >> +Introduction >> +============ >> + >> +This file documents the Intel IPU6 (6th generation Image Processing Unit) >> +Input System (MIPI CSI2 receiver) drivers located under >> +drivers/media/pci/intel/ipu6. >> + >> +The Intel IPU6 can be found in certain Intel Chipsets but not in all SKUs: >> + >> +* TigerLake >> +* JasperLake >> +* AlderLake >> +* RaptorLake >> +* MeteorLake >> + >> +Intel IPU6 is made up of two components - Input System (ISYS) and Processing >> +System (PSYS). >> + >> +The Input System mainly works as MIPI CSI2 receiver which receives and >> +processes the imaging data from the sensors and outputs the frames to memory. >> + >> +There are 2 driver modules - intel_ipu6 and intel_ipu6_isys. intel_ipu6 is an >> +IPU6 common driver which does PCI configuration, firmware loading and parsing, >> +firmware authentication, DMA mapping and IPU-MMU (internal Memory mapping Unit) >> +configuration. intel_ipu6_isys implements V4L2, Media Controller and V4L2 >> +sub-device interfaces. The IPU6 ISYS driver supports camera sensors connected >> +to the IPU6 ISYS through V4L2 sub-device sensor drivers. >> + >> +.. Note:: See Documentation/driver-api/media/drivers/ipu6.rst for more >> + information about the IPU6 hardware. > > A direct reference would be nice. > >> + >> + >> +Input system driver >> +=================== >> + >> +The input System driver mainly configures CSI2 DPHY, constructs the firmware >> +stream configuration, sends commands to firmware, gets response from hardware >> +and firmware and then returns buffers to user. >> +The ISYS is represented as several V4L2 sub-devices - 'Intel IPU6 CSI2 $port', >> +which provide V4L2 subdev interfaces to the user space, there are also several >> +video nodes for each CSI-2 stream capture - 'Intel IPU6 ISYS capture $num' which >> +provide interface to user to set formats, queue buffers and streaming. >> + >> +.. kernel-figure:: ipu6_isys_graph.svg >> + :alt: ipu6 isys media graph without multiple streams support >> + >> + ipu6 isys media graph without multiple streams support >> + >> +.. kernel-figure:: ipu6_isys_multi.svg >> + :alt: ipu6 isys media graph with multiple streams support >> + >> + ipu6 isys media graph with multiple streams support > > Is there a reason for having links from the CSI-2 receivers' source pads to > multiple video nodes? Isn't a single one enough? > Sorry, I forgot to reply before. Firmware sees each MIPI VC as a single stream, for multiple VCs case, SW need create multiple firmware streams. -- Best regards, Bingbu Cao