Received: from eggs.gnu.org ([2001:4830:134:3::10]:60038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZucA4-0000wp-VV for qemu-devel@nongnu.org; Fri, 06 Nov 2015 03:14:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZucA4-00038q-3W for qemu-devel@nongnu.org; Fri, 06 Nov 2015 03:14:16 -0500 Message-ID: <563C6151.9070800@msgid.tls.msk.ru> Date: Fri, 06 Nov 2015 11:14:09 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1446744293-32365-1-git-send-email-wei@redhat.com> In-Reply-To: <1446744293-32365-1-git-send-email-wei@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH Trivial V2] hw/intc/arm_gic: Remove the definition of NUM_CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Huang , qemu-arm@nongnu.org Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, afaerber@suse.de, qemu-devel@nongnu.org 05.11.2015 20:24, Wei Huang wrote: > arm_gic.c retrieves CPU number using either NUM_CPU(s) or s->num_cpu. > Such mixed-uses make source code inconsistent. This patch removes > NUM_CPU(s), which was defined for MPCore tweak long ago, and instead > favors s->num_cpu. The source is more consistent after this small tweak= . >=20 > Reviewed-by: Andreas F=C3=A4rber > Signed-off-by: Wei Huang Reviewed-by: Michael Tokarev I'm not applying this to -trivial per previous comments. Thanks, /mjt