From: Richard Henderson Subject: Re: [PATCH 1/2] target-i386: tcg: Accept clwb instruction Date: Fri, 6 Nov 2015 12:04:56 +0100 Message-ID: <563C8958.20709@twiddle.net> References: <1446672286-9136-1-git-send-email-ehabkost@redhat.com> <1446672286-9136-2-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , Paolo Bonzini , kvm@vger.kernel.org To: Eduardo Habkost , qemu-devel@nongnu.org Return-path: Received: from mail-wm0-f50.google.com ([74.125.82.50]:34234 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032978AbbKFLFJ (ORCPT ); Fri, 6 Nov 2015 06:05:09 -0500 Received: by wmnn186 with SMTP id n186so38687914wmn.1 for ; Fri, 06 Nov 2015 03:05:08 -0800 (PST) In-Reply-To: <1446672286-9136-2-git-send-email-ehabkost@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/04/2015 10:24 PM, Eduardo Habkost wrote: > Accept the clwb instruction (66 0F AE /6) if its corresponding feature > flag is enabled on CPUID[7]. > > Signed-off-by: Eduardo Habkost > --- > target-i386/translate.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/target-i386/translate.c b/target-i386/translate.c > index b400d24..bac1685 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -7716,10 +7716,21 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, > } > break; > case 5: /* lfence */ > - case 6: /* mfence */ > if ((modrm & 0xc7) != 0xc0 || !(s->cpuid_features & CPUID_SSE2)) > goto illegal_op; > break; > + case 6: /* mfence/clwb */ > + if (s->prefix & PREFIX_DATA) { > + /* clwb */ > + if (!(s->cpuid_7_0_ebx_features & CPUID_7_0_EBX_CLWB)) > + goto illegal_op; > + gen_lea_modrm(env, s, modrm); You should use gen_nop_modrm here, since we're not going to do anything with the address. Otherwise, Reviewed-by: Richard Henderson r~