From: Andrew Donnellan Date: Sun, 08 Nov 2015 22:56:27 +0000 Subject: Re: [PATCH] cxl: Delete an unnecessary check before the function call "kfree" Message-Id: <563FD31B.3090807@au1.ibm.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <563C7B7A.2080403@users.sourceforge.net> In-Reply-To: <563C7B7A.2080403@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , Ian Munsie , Michael Neuling , linuxppc-dev@lists.ozlabs.org Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML On 06/11/15 21:05, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 6 Nov 2015 11:00:23 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Thanks for picking this up - will remember in my future patches. Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work) IBM Australia Limited