From: Paolo Bonzini Date: Wed, 18 Nov 2015 11:04:02 +0000 Subject: Re: [PATCH] KVM-async_pf: Delete an unnecessary check before the function call "kmem_cache_destroy" Message-Id: <564C5B22.6010809@redhat.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5648543E.1000202@users.sourceforge.net> In-Reply-To: <5648543E.1000202@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , Gleb Natapov Cc: kvm@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On 15/11/2015 10:45, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Nov 2015 10:40:36 +0100 > > The kmem_cache_destroy() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > virt/kvm/async_pf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c > index 77d42be..3531599 100644 > --- a/virt/kvm/async_pf.c > +++ b/virt/kvm/async_pf.c > @@ -57,8 +57,7 @@ int kvm_async_pf_init(void) > > void kvm_async_pf_deinit(void) > { > - if (async_pf_cache) > - kmem_cache_destroy(async_pf_cache); > + kmem_cache_destroy(async_pf_cache); > async_pf_cache = NULL; > } > > Applied to kvm/queue, thanks. Paolo