Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E6E5C433F5 for ; Fri, 22 Apr 2022 00:06:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F86F83D62; Fri, 22 Apr 2022 02:06:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nQE6aoMt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1F26683D7A; Fri, 22 Apr 2022 02:06:49 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0B09E83CF3 for ; Fri, 22 Apr 2022 02:06:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x835.google.com with SMTP id fu34so4469594qtb.8 for ; Thu, 21 Apr 2022 17:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hSUCRQRyABLEEzwHtdbWMD2funFYPAFtKLdbsfajGJo=; b=nQE6aoMthV8L86IF6S23807km41fdGgufzBJiRp6Xm9Kw4HZ8nP6KPMfrsBFEsbZTa GX8xuBfbwUkSi0oFPt1z8CwYPNWBNDjFRr4PXOxqu44qjMahpq6sde78DlWWOwaZqNHo yqWrfo3Ais6nC3w7RS3GjFyX1fiuBkWYChNZ+rjfBvPJaXL58mvX8RQRf3fK0E/ZSvJD gS+x8GLFouoMQcfyD/dj1J/Io2IAOAtD30RqFpI94uu7kbhP5aTTKcfSvXR1C1HgOIUI qDqOtCYaNe9tdaSFq1LD4q9IzDhqmdas4YtDW+us2PelhZchwJ5jNGgYtysdFrnUEQj/ 8Wqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hSUCRQRyABLEEzwHtdbWMD2funFYPAFtKLdbsfajGJo=; b=kcOSJKE5U23LB55EpREAf65t09/6KJrm0me+SgBOnj3dIkhlKxTbTOVxRHStMBvHKS +uONuUWdlNIten8amvRAOAwdg9Vsm2KsATL+XDODdbYexE9hZceYTFmNA0+hQsxSP/ZS b1u03jfIb69x0P5yTIF4YYAF8RqwNeYTO6FAh5ylVtXoSFDeA78sv/Y6HAFVtUiobNjY hTokI/QZeoFP4PIZNzhCP4lDMJY4LGfGXfm6f0yglWo8HnLJyXZpwfFZCcH7yVgxTqQI rd/puVo5zccxeCCIWeT+H1WxNGnFiKwZDGF6X1Q3bopfE5rNiDxz8F8HOz6tVrA6aUb6 +lHA== X-Gm-Message-State: AOAM530frraByrCVypa/8ki3StjFL+M+QZnvO4YNqKxDxpRmyZcVehrK VFbEc7YJ0/wS94xRODd1NHU= X-Google-Smtp-Source: ABdhPJxZeHnopn+hOf2L1Q7dwn8RdRLt/i1zv0JnnLGVzoUgjwn1SSq1kcwYSrdX4uwyZx7uuRzcgg== X-Received: by 2002:ac8:7088:0:b0:2f1:e898:2971 with SMTP id y8-20020ac87088000000b002f1e8982971mr1462776qto.152.1650586004877; Thu, 21 Apr 2022 17:06:44 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id h5-20020a05622a170500b002f33ec7a932sm336707qtk.79.2022.04.21.17.06.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 17:06:44 -0700 (PDT) Subject: Re: [PATCH] led: Configure LED default-state on boot To: Patrice CHOTARD , Marek Vasut , u-boot@lists.denx.de Cc: Alex Nemirovsky , Patrick Delaunay , Philippe Reynes , Simon Glass , Steven Lawrance References: <20220403232327.720900-1-marex@denx.de> <051116fd-2619-fe62-cd1d-6b1ab64e9949@foss.st.com> <1eb6ece0-e62c-e63b-da81-6455a6a18c5b@foss.st.com> From: Sean Anderson Message-ID: <564bcf5b-11c2-7ae3-66e5-4d208fbeece0@gmail.com> Date: Thu, 21 Apr 2022 20:06:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1eb6ece0-e62c-e63b-da81-6455a6a18c5b@foss.st.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/21/22 11:26 AM, Patrice CHOTARD wrote: > > > On 4/21/22 17:18, Marek Vasut wrote: >> On 4/21/22 17:09, Patrice CHOTARD wrote: >>> Hi Marek >> >> Hi, >> >>> I tested the current U-Boot master branch (22bfaa1f673ab5442dfb9778eea4c9a18dee42d0) >>> This patch is breaking the boot sequence on stm32mp157c-dk2. >> >> Breaking it ... how ? What happens, hang ? > > Here is the boot log : > > U-Boot SPL 2022.04-00827-g22bfaa1f67 (Apr 21 2022 - 17:22:47 +0200) > RAM: DDR3-DDR3L 16bits 533000kHz > WDT: Started watchdog@5a002000 with servicing (32s timeout) > > > U-Boot 2022.04-00827-g22bfaa1f67 (Apr 21 2022 - 17:22:47 +0200) > > CPU: STM32MP157CAC Rev.B > Model: STMicroelectronics STM32MP157C-DK2 Discovery Board > Board: stm32mp1 in basic mode (st,stm32mp157c-dk2) > Board: MB1272 Var2.0 Rev.C-01 > DRAM: 512 MiB > Clocks: > - MPU : 0 MHz > - MCU : 0 MHz > - AXI : 0 MHz > - PER : 0 MHz > - DDR : 0 MHz > clock rate is 0 > clock rate is 0 > clock rate is 0 > clock rate is 0 > clock rate is 0 > cloc > > What worried me is that all clocks are set to 0 (MPU/MCU/AXI ....)...no direct link with the led-uclass update. > For information, if i comment the device_probe(dev) in led_post_bind(), it avoid the hang. Can you try applying the LED patch on top of 2022.04? I made some clock changes recently, so it could be an interaction with that. --Sean