References: <564BA6DB.4070703@...2070...> <564DE8B3.9030803@...2070...> <20151124083944.GY24952@...1296...> <5654A314.3080607@...2070...> <20151124201135.GM24952@...1296...> <565547AB.9030607@...2070...> <20151125075416.GR24952@...1296...> From: Arne Schwabe Message-ID: <5655C387.40805@...1227...> Date: Wed, 25 Nov 2015 15:19:51 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------020900010300090808040506" Subject: Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns') List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Selva Nair , Gert Doering Cc: openvpn-devel This is a multi-part message in MIME format. --------------020900010300090808040506 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Am 25.11.15 um 15:15 schrieb Selva Nair: > Hi, > > On Wed, Nov 25, 2015 at 2:54 AM, Gert Doering > wrote: > > Hi, > > On Wed, Nov 25, 2015 at 08:31:23AM +0300, ValdikSS wrote: > > I need help with 2.3 build system. While the code itself would > compile fine, it won't link because I can't figure out how to link > libraries available in vista+ > > only for vista+ build and do not link it for XP. > > Cross-build using ubuntu 14.04 and mingw64, and run configure with > "configure ... LIBS='-lwhatyouneed'" for the vista+ build. > > For 2.3, that should be good enough. > > > Aha, so original question about building for winxp is probably related > to the extra libs added to Makefile.am? I think it should not be > there in the patch for 2.3 so that the code builds cleanly for XP+ > with the current 2.3 build setup. Then build specially for vista+ as > Gert wrote above. I am not sure if we want to ship separate WIN XP and Vista+ versions. Arne --------------020900010300090808040506 Content-Type: text/html; charset="windows-1252" Content-Transfer-Encoding: quoted-printable

Am 25.11.15 um 15:15 schrieb Selva Nair:

Hi,

On Wed, Nov 25, 2015 at 2:54 AM, Gert Doering <gert@...1= 296...> wrote:

Hi,<= br>
On Wed, Nov 25, 2015 at 08:31:23AM +0300, ValdikSS wrote:
> I need help with 2.3 build system. While the code itself would compile fine, it won't link because I can't figure out how to link libraries available in vista+
> only for vista+ build and do not link it for XP.

Cross-build using ubuntu 14.04 and mingw64, and run configure with
"configure ... LIBS=3D'-lwhatyouneed'" for the vista+ build.

For 2.3, that should be good enough.

Aha, so original question about building for winxp is probably related to the extra libs added to Makefile.am?=A0 I think it should not be there in the patch for 2.3 so that the code builds cleanly for XP+ with the current 2.3 build setup. Then build specially for vista+ as Gert wrote above.

I am not sure if we want to ship separate WIN XP and Vista+ versions.

Arne
--------------020900010300090808040506--