Received: from eggs.gnu.org ([2001:4830:134:3::10]:36651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1hIJ-00070E-3Q for qemu-devel@nongnu.org; Wed, 25 Nov 2015 16:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1hIF-00054A-TC for qemu-devel@nongnu.org; Wed, 25 Nov 2015 16:08:03 -0500 References: <1448485417-8196-1-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <56562329.5040109@redhat.com> Date: Wed, 25 Nov 2015 14:07:53 -0700 MIME-Version: 1.0 In-Reply-To: <1448485417-8196-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8orhtRoIsGxlSbvlh3L0vJJVLrUfv2w86" Subject: Re: [Qemu-devel] [PATCH v2] util/id: fully allocate names table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, jcody@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8orhtRoIsGxlSbvlh3L0vJJVLrUfv2w86 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/25/2015 02:03 PM, John Snow wrote: > Trivial: this array should be allocated to have ID_MAX entries always. > Otherwise if someone were to forget to expand this table, the assertion= > in the id generator won't actually trigger; it will read junk data. >=20 > v2: Fix the range assertion, too. Compare against the known actual size= > of the table instead of what it "should" be. The v2 blurb would normally appear after the ---; it can be removed by the maintainer. >=20 > Signed-off-by: John Snow > --- > util/id.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8orhtRoIsGxlSbvlh3L0vJJVLrUfv2w86 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWViMpAAoJEKeha0olJ0NqQIcH/3ahFRDkk6yVwJPgLY/AImvg sWncjvAAIpjinYzW+QUcudIo1QK8Dy/hh+bNMqoUuPDpeaOB0DjL5+PNSXY1LEEt 2bxa01bZQpl1XIjbbMfl1oyVkCJlNLjdHYkeRVPZclxfQEDFfp/VItrBlxGIW2xz GSsZPaIo7kzjE+KKODaC/z1UIvOEl0i3OqLHYHmG+WDlb3FrQDIv0StA3uW5A3x2 wJBuNTnPmsIX496RLrA+Tc7kvfBGKUeQNstdgVzJePfDv62cPKC7YMJnCZIJNAWw xcwd0VY/yo/HFthTyQBHC8O7aYwE/n0/oJfzluMHEKTRXwFXWSgixVmBifgktOQ= =w9DS -----END PGP SIGNATURE----- --8orhtRoIsGxlSbvlh3L0vJJVLrUfv2w86--