Received: by 10.182.158.201 with SMTP id ww9csp175694obb; Fri, 27 Nov 2015 14:05:44 -0800 (PST) X-Received: by 10.140.136.134 with SMTP id 128mr30122873qhi.16.1448661944278; Fri, 27 Nov 2015 14:05:44 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id q64si33167242qha.51.2015.11.27.14.05.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 27 Nov 2015 14:05:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:58696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2R9D-00007v-Ok for alex.bennee@linaro.org; Fri, 27 Nov 2015 17:05:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2R9A-00007N-Gs for qemu-arm@nongnu.org; Fri, 27 Nov 2015 17:05:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2R94-0003Xq-UY for qemu-arm@nongnu.org; Fri, 27 Nov 2015 17:05:40 -0500 Received: from zose-mta03.web4all.fr ([185.49.20.44]:39575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2R94-0003XX-Iv; Fri, 27 Nov 2015 17:05:34 -0500 Received: from localhost (localhost [127.0.0.1]) by zose-mta03.web4all.fr (Postfix) with ESMTP id EAD5B4163A; Fri, 27 Nov 2015 23:05:32 +0100 (CET) Received: from zose-mta03.web4all.fr ([127.0.0.1]) by localhost (zose-mta03.web4all.fr [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1Sc3WW774mwl; Fri, 27 Nov 2015 23:05:32 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zose-mta03.web4all.fr (Postfix) with ESMTP id 0FB9641640; Fri, 27 Nov 2015 23:05:32 +0100 (CET) X-Virus-Scanned: amavisd-new at zose-mta-03.w4a.fr Received: from zose-mta03.web4all.fr ([127.0.0.1]) by localhost (zose-mta03.web4all.fr [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0AkCfQsf0Fov; Fri, 27 Nov 2015 23:05:31 +0100 (CET) Received: from [192.168.1.128] (smm49-1-78-235-240-156.fbx.proxad.net [78.235.240.156]) by zose-mta03.web4all.fr (Postfix) with ESMTPSA id 9F27A4163A; Fri, 27 Nov 2015 23:05:31 +0100 (CET) To: Peter Crosthwaite , Guenter Roeck References: <5658B4EA.8070005@tribudubois.net> From: Jean-Christophe DUBOIS Message-ID: <5658D3AA.9040305@tribudubois.net> Date: Fri, 27 Nov 2015 23:05:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.49.20.44 Cc: Peter Maydell , qemu-arm@nongnu.org, "qemu-devel@nongnu.org Developers" Subject: Re: [Qemu-arm] [PATCH v4 3/3] i.MX: Add an i.MX25 specific CCM class/instance. X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: 7v4znmBnRX54 Le 27/11/2015 21:26, Peter Crosthwaite a =C3=A9crit : > On Fri, Nov 27, 2015 at 11:54 AM, Jean-Christophe DUBOIS > wrote: >> Le 27/11/2015 03:39, Peter Crosthwaite a =C3=A9crit : >> >> On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois >> wrote: >> >> Signed-off-by: Jean-Christophe Dubois >> >> This seems to slow down boot performance for i.MX25 Linux. Admittedly, >> the issue looks to be in timeout code for an unmodelled periph (NAND): >> >> ------------[ cut here ]------------ >> WARNING: CPU: 0 PID: 1 at >> /home/pcrost/poky/build/tmp/work-shared/qemuarmv5imx/kernel-source/dri= vers/mtd/nand/mxc_nand.c:464 >> wait_op_done+0xf0/0x114() >> timeout! useirq=3D0 >> Modules linked in: >> CPU: 0 PID: 1 Comm: swapper Not tainted 4.2.1 #1 >> Hardware name: Freescale i.MX25 (Device Tree Support) >> [] (unwind_backtrace) from [] (show_stack+0x10/0x1= 4) >> [] (show_stack) from [] (warn_slowpath_common+0x74= /0xac) >> [] (warn_slowpath_common) from [] >> (warn_slowpath_fmt+0x30/0x40) >> [] (warn_slowpath_fmt) from [] (wait_op_done+0xf0/= 0x114) >> [] (wait_op_done) from [] (nand_scan_ident+0xdc/0x= 1560) >> [] (nand_scan_ident) from [] (mxcnd_probe+0x378/0x= 5c0) >> [] (mxcnd_probe) from [] (platform_drv_probe+0x44/= 0xac) >> [] (platform_drv_probe) from [] >> (driver_probe_device+0x180/0x2c4) >> [] (driver_probe_device) from [] >> (__driver_attach+0x8c/0x90) >> [] (__driver_attach) from [] >> (bus_for_each_dev+0x70/0xa0) >> [] (bus_for_each_dev) from [] >> (bus_add_driver+0x188/0x210) >> [] (bus_add_driver) from [] (driver_register+0x78/= 0xf8) >> [] (driver_register) from [] >> (do_one_initcall+0x84/0x1f0) >> [] (do_one_initcall) from [] >> (kernel_init_freeable+0x108/0x1c8) >> [] (kernel_init_freeable) from [] (kernel_init+0x8= /0xec) >> [] (kernel_init) from [] (ret_from_fork+0x14/0x34) >> ---[ end trace 13248cb1a1bbcb9c ]--- >> >> <> >> >> nand: No NAND device found >> ... >> >> Without this patch, the delay is around 2 seconds, with this patch it >> is 10+. Any idea what would cause it? Are you removing the NAND from >> DTS for your testing and do we not care about these errors paths? >> >> Regards, >> Peter >> >> The kernel I am testing with is 3.19.0 but without without DTS tree. >> Linux version 3.19.0 (jcd@jcd-U31SG) (gcc version 4.6.3 (GCC) ) #2 Mon= Jun >> 22 00:32:04 CEST 2015 >> >> So I am not up to date on this side and I might not test the same devi= ces as >> you do as I generated a "minimal" kernel for my test. >> > So the DTB+defconfig boot is actually in pretty good shape. That NAND > thing is the only real bootlog issue. All other missing peripherals > fail gracefully. I tried the latest kernel (4.4.0 rc2) with full defconfig and dtb and I=20 am getting the same timeout issue even with the i.MX31 CCM module. ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at drivers/mtd/nand/mxc_nand.c:464=20 wait_op_done+0xe0/0x104() timeout! useirq=3D0 Modules linked in: CPU: 0 PID: 1 Comm: swapper Not tainted 4.4.0-rc2-00118-g1724734 #1 Hardware name: Freescale i.MX25 (Device Tree Support) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (warn_slowpath_common+0x78/0x= b0) [] (warn_slowpath_common) from []=20 (warn_slowpath_fmt+0x30/0x40) [] (warn_slowpath_fmt) from [] (wait_op_done+0xe0/0x1= 04) [] (wait_op_done) from [] (mxc_nand_command+0x150/0x4= a8) [] (mxc_nand_command) from []=20 (nand_scan_ident+0xe4/0x1580) [] (nand_scan_ident) from [] (mxcnd_probe+0x370/0x5a0= ) [] (mxcnd_probe) from [] (platform_drv_probe+0x54/0xa= 4) [] (platform_drv_probe) from []=20 (driver_probe_device+0x1e4/0x2a8) [] (driver_probe_device) from []=20 (__driver_attach+0x8c/0x90) [] (__driver_attach) from []=20 (bus_for_each_dev+0x5c/0x8c) [] (bus_for_each_dev) from []=20 (bus_add_driver+0x160/0x1f8) [] (bus_add_driver) from [] (driver_register+0x78/0xf= 4) [] (driver_register) from []=20 (do_one_initcall+0x84/0x1f4) [] (do_one_initcall) from []=20 (kernel_init_freeable+0xf8/0x1bc) [] (kernel_init_freeable) from [] (kernel_init+0x8/0x= e4) [] (kernel_init) from [] (ret_from_fork+0x14/0x24) ---[ end trace 03bc7274bbc34493 ]--- nand: No NAND device found I tried it with mainline qemu (so without any of my changes) and I still=20 run in the problem. So not sure it is related to the change in the i.MX25 CCM device. JC > >> Anyway, testing the timer code I found that running "sleep 60" on both= PTF >> doesn't give the expected 60 seconds in "real world time": >> >> On i.MX31 (using i.MX31 CCM) =3D> 47 seconds >> On i.MX25 (using i.MX31 CCM) =3D> 52 seconds (before change. close eno= ugh?) > Confirmed this result, exactly the same here. > >> On i.MX25 (using i.MX25 CCM) =3D> 80 seconds >> >> Another indication, the bogomips: >> >> On i.MX31 (using i.MX31 CCM) =3D> 78 >> On i.MX25 (using i.MX31 CCM) =3D> 87 (before change. close enough?) >> On i.MX25 (using i.MX25 CCM) =3D> 133 >> > I wouldn't worry about this, this is rarely accurate in QEMU. > > Regards, > Peter > >> So, yes, for some reason "time goes slower" after switching to i.MX25 = CCM >> ... (but it was also going too fast before with i.MX31 CCM) >> >> As the CCM doesn't really provide any clock (just a clock value) somet= hing >> must not be right in the way the i.MX GPT timer is computing time. >> >> I need to look after this. >> >> JC >> >> --- >> >> Changes since v1: >> * rework loging to match other i.MX drivers >> >> Changes since v2: >> * We moved to an inheritance QOM scheme >> >> Changes since v3: >> * Rework logging based on comments. >> >> hw/arm/fsl-imx25.c | 2 +- >> hw/misc/Makefile.objs | 1 + >> hw/misc/imx25_ccm.c | 276 >> ++++++++++++++++++++++++++++++++++++++++++++ >> include/hw/arm/fsl-imx25.h | 4 +- >> include/hw/misc/imx25_ccm.h | 59 ++++++++++ >> 5 files changed, 339 insertions(+), 3 deletions(-) >> create mode 100644 hw/misc/imx25_ccm.c >> create mode 100644 include/hw/misc/imx25_ccm.h >> >>