Received: from eggs.gnu.org ([2001:4830:134:3::10]:49335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2zRL-0002lS-K2 for qemu-devel@nongnu.org; Sun, 29 Nov 2015 05:42:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2zRG-0000RL-LJ for qemu-devel@nongnu.org; Sun, 29 Nov 2015 05:42:43 -0500 Message-ID: <565AD69D.5090507@msgid.tls.msk.ru> Date: Sun, 29 Nov 2015 13:42:37 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1447436727-26484-1-git-send-email-berrange@redhat.com> In-Reply-To: <1447436727-26484-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] crypto: avoid two coverity false positive error reports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Paolo Bonzini 13.11.2015 20:45, Daniel P. Berrange wrote: > In qcrypto_tls_creds_get_path() coverity complains that > we are checking '*creds' for NULL, despite having > dereferenced it previously. This is harmless bug due > to fact that the trace call was too early. Moving it > after the cleanup gets the desired semantics. ... Applied to -trivial, thank you! /mjt