From: Michael Wang Subject: Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Date: Wed, 2 Dec 2015 14:07:52 +0100 Message-ID: <565EED28.7050308@profitbricks.com> References: <564F051E.9010703@profitbricks.com> <20151125150806.GG2064@8bytes.org> <5655D072.1000901@profitbricks.com> <565EC9F4.2050401@profitbricks.com> <565ECE54.5080706@profitbricks.com> <565ED81B.3020606@profitbricks.com> <20151202115142.GD18805@8bytes.org> <565EE4AA.4070309@profitbricks.com> <20151202125636.GE18805@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151202125636.GE18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Linux Kernel Mailing List , Catalin Marinas List-Id: iommu@lists.linux-foundation.org On 12/02/2015 01:56 PM, Joerg Roedel wrote: > On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote: >> It's not my work or your work... it's a defect in the module and maintainer >> should take responsibility on fixing it, correct? > > No, its a false positive from an in-kernel checking tool, the iommu > driver is correct. You just sent a patch to silence the false positive > report. Yeah, but caused by the driver :-P and have to be fixed in there too. > >> We're very willing to help, but as I mentioned we are out of resource for >> testing at this moment, but we can send you a new patch without testing, >> will that works for you? > > This should be testable on any AMD IOMMU system with working interrupt > remapping. I will probably have no time to test this, if you really > can't test yourself, try to get a Tested-by from someone else. Good point, anyone willing to help test the fix? Or better provide the new patch to be the author. Regards, Michael Wang > > > > Joerg >