From: "d12fk (Code Review)"
Date: Tue, 8 Jul 2025 13:15:20 +0000
In-Reply-To:
References:
Reply-To: heiko@...515..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <565ece55e358af5d72e18e0c7287a69ae307e7cc-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="//QPonSVxL4="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: mac dns: do not run
dns-updown in parallel
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , flichtenheld , openvpn-devel
--//QPonSVxL4=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/1076?usp=3Demail )
Change subject: mac dns: do not run dns-updown in parallel
......................................................................
Patch Set 2:
(1 comment)
File distro/dns-scripts/macos-dns-updown.sh:
http://gerrit.openvpn.net/c/openvpn/+/1076/comment/8dbf5453_c73f60d9 :
PS2, Line 30: lockfile=3D/tmp/openvpn-dns-updown.lock
> I have one that is from 2011 on my system =F0=9F=98=8A [=E2=80=A6]
Did a little bit of research, but found nothing in particular about the mis=
sing /var/lock in macOS. /var/run seems not to be the right dir either, giv=
en its original purpose. Are you concerned that the lock file will be clean=
ed up while in use because it is stored in /tmp? In that case I'd rather cr=
eate /var/lock if it doesn't exist. I think /tmp is good enough, tough.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1076?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7adfaa08df6a17545cca8264d7230b5e65e49719
Gerrit-Change-Number: 1076
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Tue, 08 Jul 2025 13:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos
Comment-In-Reply-To: d12fk
Gerrit-MessageType: comment
--//QPonSVxL4=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
I have one that is fr=
om 2011 on my system =F0=9F=98=8A [=E2=80=A6]
Did a little bit of research,=
but found nothing in particular about the missing /var/lock in macOS. /var=
/run seems not to be the right dir either, given its original purpose. Are =
you concerned that the lock file will be cleaned up while in use because it=
is stored in /tmp? In that case I'd rather create /var/lock if it does=
n't exist. I think /tmp is good enough, tough.
<=
p>To view, visit change 1076. To unsubscribe, or for help writing mail filters=
, visit settings.