References: <565A3985.3030800@...1227...> <1448835033-24287-1-git-send-email-iam@...2070...> <5660EA2A.1020903@...515...> <5661214C.8040905@...2070...> From: ValdikSS Message-ID: <5661686A.4090305@...2070...> Date: Fri, 4 Dec 2015 13:18:18 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9TBWGDJn0pJ04vLC0QBPALxKhQ0eXQ5n2" Subject: Re: [Openvpn-devel] [PATCH v7-master] Add Windows DNS Leak fix using WFP ('block-outside-dns') List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Selva Nair Cc: James Yonan , "openvpn-devel@lists.sourceforge.net" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9TBWGDJn0pJ04vLC0QBPALxKhQ0eXQ5n2 Content-Type: multipart/alternative; boundary="------------080103060901090608040807" This is a multi-part message in MIME format. --------------080103060901090608040807 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Indeed. Pushed fixed version to github repo. https://github.com/ValdikSS/openvpn-with-patches/commit/287ceb11abfa33ee331= ba2651572908cbad008d1 If there is no other remarks, I'll send PATCH v8. On 04.12.2015 08:50, Selva Nair wrote: > Hi, > > On Fri, Dec 4, 2015 at 12:14 AM, ValdikSS > wrote: > > I think you missed the NET_LUID one. I had thought this was fixed earlier= , but v7 still has this issue > > > The relevant code is > > + if (ConvertInterfaceIndexToLuid(index, &tapluid) =3D=3D NO_ERROR) > + dmsg (D_LOW, "Tap Luid: %I64d", tapluid.Value); > > which leaves tapluid undefined if there was an error. > > Selva > --------------080103060901090608040807 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Indeed.
Pushed fixed version to github repo.
https://github.com/ValdikSS/openvpn-with-patches/comm= it/287ceb11abfa33ee331ba2651572908cbad008d1

If there is no other remarks, I'll send PATCH v8.

On 04.12.2015 08:50, Selva Nair wrote:
Hi,

On Fri, Dec 4, 2015 at 12:14 AM, ValdikSS <iam@...2098...= 0...> wrote:

I think you missed the NET_LUID one. I had thought this was fixed earlier, but v7 still has this issue


The relevant code is

+ if (ConvertInterfaceIndexToLuid(index, &tapluid) =3D=3D NO_ERROR)
+ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dmsg (D_LOW, "Tap Luid: %I64d"= , tapluid.Value);

which leaves tapluid undefined if there was an error.

Selva


--------------080103060901090608040807-- --9TBWGDJn0pJ04vLC0QBPALxKhQ0eXQ5n2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: https://keybase.io/valdikss iQIcBAEBCAAGBQJWYWhqAAoJEFzXIC7viPdygY8QALHTWaqX3UyAwuGSgxBwvgTv X4oXYns/wlKTOUmJWUqFXxbFSiug3EoiK0gj61tyuAkPsBhL2+7lmGaQKVa7TOR/ jgnmMqRs9uxWuQj0EC/ajXu8/JizikEDkFfE37bFvNtsnUYuXr6mLg/YTXn5sF6W i+YPDgq/+4F44XE/BMhxoGWlu/3XsartBBenacJ3u7bREs6fBmz9XjcAoI/T4Q7+ WpoUrZmSgocq2t+VsQW6n/7BibhymfU4BJUniouzvIEddNNvlU0AN8SLdeulfDUw LbXe8nVhEJsDUJaMS0Nx8pqm1t6iSLAbaRWWJIF5FM8bBkrijNL9ULLIB1ZdTiTG i79rtOeVWL+c6yizW5V/wNnC8sKerP+PbQLaFJnNsaW+ZrP79seBXmI8TWwLU8rz xAxmXTga+X0ralVfWluQnjzn5W28LW7hJHgKYbUi5/2zRkmMB11aSPxH1/o8TwYR GHB4XVhoVHDLtHKPsSpBcWwGzr2FlElGB5p/olZbct5uHm/Fx6KaViMxv/9VbNtZ yWu1Olhf/wyOIXMq2bj1+7T7HuZ6sdGydj6uniLuhtk14VG6bWu627LaNBAkVDKi S1WBfDFkaeMgES/0px0SHubpjvFcGq+/1sK3a3fC3vjWoP6eIAa9QkTtQ553rVVg B+uyIu5mYnKIg0ymb74f =+k8O -----END PGP SIGNATURE----- --9TBWGDJn0pJ04vLC0QBPALxKhQ0eXQ5n2--