Received: from eggs.gnu.org ([2001:4830:134:3::10]:39213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6o6r-0005EB-Bt for qemu-devel@nongnu.org; Wed, 09 Dec 2015 18:25:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6o6n-0000Eu-8b for qemu-devel@nongnu.org; Wed, 09 Dec 2015 18:25:21 -0500 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:50904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6o6n-0000Dz-2G for qemu-devel@nongnu.org; Wed, 09 Dec 2015 18:25:17 -0500 References: <1449241262-3002-1-git-send-email-azu@sysgo.de> <566736A3.30503@twiddle.net> From: Mark Cave-Ayland Message-ID: <5668B843.9020007@ilande.co.uk> Date: Wed, 9 Dec 2015 23:24:51 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5] sparc: allow CASA with ASI 0xa from user space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Richard Henderson Cc: Alex Zuepke , QEMU Developers , Fabien Chouteau On 08/12/15 21:28, Peter Maydell wrote: > On 8 December 2015 at 19:59, Richard Henderson wrote: >> On 12/04/2015 07:01 AM, Alex Zuepke wrote: >>> LEON3 allows the CASA instruction to be used from user space >>> if the ASI is set to 0xa (user data). >>> >>> Signed-off-by: Alex Zuepke >>> --- >>> target-sparc/translate.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/target-sparc/translate.c b/target-sparc/translate.c >>> index 41a3319..63440dd 100644 >>> --- a/target-sparc/translate.c >>> +++ b/target-sparc/translate.c >>> @@ -5097,7 +5097,8 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) >>> if (IS_IMM) { >>> goto illegal_insn; >>> } >>> - if (!supervisor(dc)) { >>> + /* LEON3 allows CASA from user space with ASI 0xa */ >>> + if ((GET_FIELD(insn, 19, 26) != 0xa) && !supervisor(dc)) { >>> goto priv_insn; >>> } >>> #endif >>> >> >> Reviewed-by: Richard Henderson >> >> This should probably be merged for 2.5. > > Very late, but a very small patch which only affects TCG SPARC, > so I'm OK with applying it to master. (Mark, did you want to ack/review?) My understanding from this thread is that it only affects LEON3 - while I don't have any such images to test with, given that it's restricted to LEON3 then I'd be fine if you were to apply this to master with an R-B from Richard and Fabien (I'll do another OpenBIOS test suite run over the weekend just to be sure). ATB, Mark.