From: SF Markus Elfring Date: Sat, 19 Dec 2015 17:00:36 +0000 Subject: [PATCH] pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup() Message-Id: <56758D34.2070806@users.sourceforge.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-gpio@vger.kernel.org, Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sat, 19 Dec 2015 17:55:39 +0100 The return type "unsigned int" was used by the adi_gpio_irq_startup() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type modifier then. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-adi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c index fd342df..4032004 100644 --- a/drivers/pinctrl/pinctrl-adi2.c +++ b/drivers/pinctrl/pinctrl-adi2.c @@ -329,7 +329,7 @@ static void adi_gpio_unmask_irq(struct irq_data *d) spin_unlock_irqrestore(&port->lock, flags); } -static unsigned int adi_gpio_irq_startup(struct irq_data *d) +static int adi_gpio_irq_startup(struct irq_data *d) { unsigned long flags; struct gpio_port *port = irq_data_get_irq_chip_data(d); -- 2.6.3