Received: from eggs.gnu.org ([2001:4830:134:3::10]:34722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAc8V-00040J-Rk for qemu-devel@nongnu.org; Sun, 20 Dec 2015 06:26:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aAc8R-0004bR-CI for qemu-devel@nongnu.org; Sun, 20 Dec 2015 06:26:47 -0500 References: <20151220111608.6664.85476.stgit@bahia.local> From: Michael Tokarev Message-ID: <56769069.6040105@msgid.tls.msk.ru> Date: Sun, 20 Dec 2015 14:26:33 +0300 MIME-Version: 1.0 In-Reply-To: <20151220111608.6664.85476.stgit@bahia.local> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-9p: use accessor to get thread_pool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: qemu-devel@nongnu.org, Paolo Bonzini , qemu-stable@nongnu.org, "Aneesh Kumar K.V" 20.12.2015 14:19, Greg Kurz wrote: > The aio_context_new() function does not allocate a thread pool. This is > deferred to the first call to the aio_get_thread_pool() accessor. It is > hence forbidden to access the thread_pool field directly, as it may be > NULL. The accessor *must* be used always. > > Fixes: ebac1202c95a4f1b76b6ef3f0f63926fa76e753e > Signed-off-by: Greg Kurz Reviewed-by: Michael Tokarev Tested-by: Michael Tokarev Cc: qemu-stable@nongnu.org > Michael, > > I did not have time to reproduce the issue, and therefore to > effectively test this patch fixes it. Maybe you can do it ? Yes, it effectively fixes the issue. Meanwhile I looked at the whole thing with how thread pools are allocated, and now can add my R-b too. Thank you! /mjt