From: Yaodong Li Subject: Re: [PATCH v4 1/4] drm/i915: Always do WOPCM partitioning based on real firmware sizes Date: Thu, 19 Apr 2018 15:29:59 -0700 Message-ID: <5687d0df-8a8f-5e93-4ed3-1ed242e1ff94@intel.com> References: <1524070894-8120-1-git-send-email-yaodong.li@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id BEEF76E687 for ; Thu, 19 Apr 2018 22:32:20 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDQvMTkvMjAxOCAwODo0NSBBTSwgTWljaGFsIFdhamRlY3prbyB3cm90ZToKPiBPbiBXZWQs IDE4IEFwciAyMDE4IDE5OjAxOjMxICswMjAwLCBKYWNraWUgTGkgPHlhb2RvbmcubGlAaW50ZWwu Y29tPiAKPiB3cm90ZToKPgo+PiBBZnRlciBlbmFibGVkIHRoZSBXT1BDTSB3cml0ZS1vbmNlIHJl Z2lzdGVycyBsb2NraW5nIHN0YXR1cyBjaGVja2luZywKPj4gcmVsb2FkaW5nIG9mIHRoZSBpOTE1 IG1vZHVsZSB3aWxsIGZhaWwgd2l0aCBtb2RwYXJhbSBlbmFibGVfZ3VjIHNldCB0byAzCj4+IChl bmFibGUgR3VDIGFuZCBIdUMgZmlybXdhcmUgbG9hZGluZykgaWYgdGhlIG1vZHVsZSB3YXMgb3Jp Z2luYWxseSAKPj4gbG9hZGVkCj4+IHdpdGggZW5hYmxlX2d1YyBzZXQgdG8gMSAob25seSBlbmFi bGUgR3VDIGZpcm13YXJlIGxvYWRpbmcpLiBUaGlzIGlzCj4+IGJlY2F1c2UgV09QQ00gcmVnaXN0 ZXJzIHdlcmUgdXBkYXRlZCBhbmQgbG9ja2VkIHdpdGhvdXQgY29uc2lkZXJpbmcgCj4+IHRoZSBI dUMKPj4gRlcgc2l6ZS4gU2luY2Ugd2UgbmVlZCBib3RoIEd1QyBhbmQgSHVDIEZXIHNpemVzIHRv IGRldGVybWluZSB0aGUgZmluYWwKPj4gbGF5b3V0IG9mIFdPUENNLCB3ZSBzaG91bGQgYWx3YXlz IGNhbGN1bGF0ZSB0aGUgV09QQ00gbGF5b3V0IGJhc2VkIG9uIAo+PiB0aGUKPj4gYWN0dWFsIHNp emVzIG9mIHRoZSBHdUMgYW5kIEh1QyBmaXJtd2FyZSBhdmFpbGFibGUgZm9yIGEgc3BlY2lmaWMg Cj4+IHBsYXRmb3JtCj4+IGlmIHdlIG5lZWQgY29udGludWUgdG8gc3VwcG9ydCBlbmFibGUvZGlz YWJsZSBIdUMgRlcgbG9hZGluZyBkeW5hbWljYWxseQo+PiB3aXRoIGVuYWJsZV9ndWMgbW9kcGFy YW0uCj4+Cj4+IFRoaXMgcGF0Y2ggc3BsaXRzIHVDIGZpcm13YXJlIGZldGNoaW5nIGludG8gdHdv IHN0YWdlcy4gRmlyc3Qgc3RhZ2UgCj4+IGlzIHRvCj4+IGZldGNoIHRoZSBmaXJtd2FyZSBpbWFn ZSBhbmQgdmVyaWZ5IHRoZSBmaXJtd2FyZSBoZWFkZXIuIHVDIGZpcm13YXJlIAo+PiB3aWxsCj4+ IGJlIG1hcmtlZCBhcyB2ZXJpZmllZCBhbmQgdGhpcyB3aWxsIG1ha2UgRlcgaW5mbyBhdmFpbGFi bGUgZm9yIGZvbGxvd2luZwo+PiBXT1BDTSBsYXlvdXQgY2FsY3VsYXRpb24uIFRoZSBzZWNvbmQg c3RhZ2UgaXMgdG8gY3JlYXRlIGEgR0VNIG9iamVjdCBhbmQKPj4gY29weSB0aGUgRlcgZGF0YSBp bnRvIHRoZSBjcmVhdGVkIEdFTSBvYmplY3Qgd2hpY2ggd2lsbCBvbmx5IGJlIAo+PiBhdmFpbGFi bGUKPj4gd2hlbiBHdUMvSHVDIGxvYWRpbmcgaXMgZW5hYmxlZCBieSBlbmFibGVfZ3VjIG1vZHBh cmFtLiBUaGlzIHdpbGwgCj4+IGd1YXJhbnRlZQo+PiB0aGF0IHRoZSBXT1BDTSBsYXlvdXQgd2ls bCBiZSBhbHdheXMgYmUgY2FsY3VsYXRlZCBjb3JyZWN0bHkgd2l0aG91dCAKPj4gbWFraW5nCj4+ IGFueSBhc3N1bXB0aW9ucyB0byB0aGUgR3VDIGFuZCBIdUMgZmlybXdhcmUgc2l6ZXMuCj4+Cj4+ IHYzOgo+PiDCoC0gUmViYXNlCj4+Cj4+IHY0Ogo+PiDCoC0gUmVuYW1lZCB0aGUgbmV3IHBhcmFt ZXRlciBhZGQgdG8gaW50ZWxfdWNfZndfZmV0Y2ggKE1pY2hhbCkKPj4KPj4gU2lnbmVkLW9mZi1i eTogSmFja2llIExpIDx5YW9kb25nLmxpQGludGVsLmNvbT4KPj4gQ2M6IE1pY2hhbCBXYWpkZWN6 a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+PiBDYzogU2FnYXIgQXJ1biBLYW1ibGUg PHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPj4gQ2M6IE1pY2hhbCBXaW5pYXJza2kgPG1pY2hh bC53aW5pYXJza2lAaW50ZWwuY29tPgo+PiBDYzogSm9obiBTcG90c3dvb2QgPGpvaG4uYS5zcG90 c3dvb2RAaW50ZWwuY29tPgo+PiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5A bGludXguaW50ZWwuY29tPgo+PiBSZXZpZXdlZC1ieTogSm9obiBTcG90c3dvb2QgPGpvaG4uYS5z cG90c3dvb2RAaW50ZWwuY29tPgo+PiAtLS0KPj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF91Yy5jwqDCoMKgIHwgMTQgKysrKy0tLS0tLS0tLS0KPj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF91Y19mdy5jIHwgMzEgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+PiDC oGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmggfMKgIDcgKysrKystLQo+PiDCoDMg ZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4+Cj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jIAo+PiBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPj4gaW5kZXggMWNmZmFmNy4uNzNiOGY2YyAxMDA2NDQK Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4+IEBAIC0xNzIsMTEgKzE3Miw4IEBAIHZvaWQgaW50 ZWxfdWNfaW5pdF9lYXJseShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAKPj4gKmk5MTUpCj4+IMKg wqDCoMKgc2FuaXRpemVfb3B0aW9uc19lYXJseShpOTE1KTsKPj4gLcKgwqDCoCBpZiAoVVNFU19H VUMoaTkxNSkpCj4+IC3CoMKgwqDCoMKgwqDCoCBpbnRlbF91Y19md19mZXRjaChpOTE1LCAmZ3Vj LT5mdyk7Cj4+IC0KPj4gLcKgwqDCoCBpZiAoVVNFU19IVUMoaTkxNSkpCj4+IC3CoMKgwqDCoMKg wqDCoCBpbnRlbF91Y19md19mZXRjaChpOTE1LCAmaHVjLT5mdyk7Cj4+ICvCoMKgwqAgaW50ZWxf dWNfZndfZmV0Y2goaTkxNSwgJmd1Yy0+ZncsIFVTRVNfR1VDKGk5MTUpKTsKPj4gK8KgwqDCoCBp bnRlbF91Y19md19mZXRjaChpOTE1LCAmaHVjLT5mdywgVVNFU19IVUMoaTkxNSkpOwo+Cj4gQWdh aW46IEknbSBkb24ndCB0aGluayB0aGF0IHVuY29uZGl0aW9uYWwgZmV0Y2ggb2YgSHVDIGZ3IGlz IGEgcmlnaHQgCj4gY2hvaWNlLgo+IFdlIHNob3VsZCBsb29rIGZvciBvdGhlciBvcHRpb25zIGhv dyB0byBzdXBwb3J0IGVuYWJsZV9ndWMgMS0tPjMgCj4gc2NlbmFyaW8uCj4KVGhpcyBpcyB0aGUg cmVhbCBmaXggSSBjYW4gdGhpbmsgb2YgdG8gc3VwcG9ydCBzdWNoIGEgc2NlbmFyaW8uIEkgdGhp bmsgCnRoZSBwZXJmb3JtYW5jZQppbXBhY3QgaGVyZSBpcyBtaW5pbWFsIHNpbmNlIGl0J3Mgb25s eSBvbmUgdGltZSBvcGVyYXRpb24uIEkgd2lsbCB0aGluayAKYWJvdXQgdGhlCnVzZSBjYXNlIG9m IEhBU19IVUMgPSAxIGFuZCBvbmx5IGVuYWJsZSBndWMgc3VibWlzc2lvbi4KCkJ1dCBmaXJzdCBJ IHN1Z2dlc3Qgd2UgbmVlZCB0byBkZWZpbmUgdGhlIGV4cGVjdGVkIHVzZSBjYXNlIChsaWtlIEkg Cm1lbnRpb25lZCBpbiBteSBsYXN0IHJlcGx5KToKaG93IHRvIGRlZmluZSAic3VwcG9ydCBlbmFi bGVfZ3VjIDEtPjMiICh3aGV0aGVyIHdlIHNob3VsZCBleHBlY3Qgc29tZSAKc3lzdGVtIHJlYm9v dCwgb3IKd2UgbmVlZCBndWFyYW50ZWUgMTAwJSB3b3JrIHdpdGggbm8gc3lzdGVtIHJlYm9vdCBy ZXF1aXJlZCk/IHdoZXRoZXIgYSAKc3lzdGVtIHJlYm9vdCBmb3IKRlcgY2hhbmdlcyBzaG91bGQg YmUgdHJlYXRlZCBhcyBjb2RlIGRlZmVjdHMsIGV0Yy4KPj4gwqB9Cj4+IHZvaWQgaW50ZWxfdWNf Y2xlYW51cF9lYXJseShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPj4gQEAgLTE4NCwx MSArMTgxLDggQEAgdm9pZCBpbnRlbF91Y19jbGVhbnVwX2Vhcmx5KHN0cnVjdCAKPj4gZHJtX2k5 MTVfcHJpdmF0ZSAqaTkxNSkKPj4gwqDCoMKgwqAgc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmk5 MTUtPmd1YzsKPj4gwqDCoMKgwqAgc3RydWN0IGludGVsX2h1YyAqaHVjID0gJmk5MTUtPmh1YzsK Pj4gLcKgwqDCoCBpZiAoVVNFU19IVUMoaTkxNSkpCj4+IC3CoMKgwqDCoMKgwqDCoCBpbnRlbF91 Y19md19maW5pKCZodWMtPmZ3KTsKPj4gLQo+PiAtwqDCoMKgIGlmIChVU0VTX0dVQyhpOTE1KSkK Pj4gLcKgwqDCoMKgwqDCoMKgIGludGVsX3VjX2Z3X2ZpbmkoJmd1Yy0+ZncpOwo+PiArwqDCoMKg IGludGVsX3VjX2Z3X2ZpbmkoJmh1Yy0+ZncpOwo+PiArwqDCoMKgIGludGVsX3VjX2Z3X2Zpbmko Jmd1Yy0+ZncpOwo+PiDCoMKgwqDCoGd1Y19mcmVlX2xvYWRfZXJyX2xvZyhndWMpOwo+PiDCoH0K Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMgCj4+IGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuYwo+PiBpbmRleCA2ZThlMGI1Li5jMWZl ZDA2IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5jCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMKPj4gQEAgLTMzLDExICsz MywxMyBAQAo+PiDCoCAqCj4+IMKgICogQGRldl9wcml2OiBkZXZpY2UgcHJpdmF0ZQo+PiDCoCAq IEB1Y19mdzogdUMgZmlybXdhcmUKPj4gKyAqIEBmZXRjaDogd2hldGhlciBmZXRjaCB1QyBmaXJt d2FyZSBpbnRvIEdFTSBvYmplY3Qgb3Igbm90Cj4+IMKgICoKPj4gLSAqIEZldGNoIHVDIGZpcm13 YXJlIGludG8gR0VNIG9iai4KPj4gKyAqIEZldGNoIGFuZCB2ZXJpZnkgdUMgZmlybXdhcmUgYW5k IGNvcHkgZmlybXdhcmUgZGF0YSBpbnRvIEdFTSAKPj4gb2JqZWN0IGlmCj4+ICsgKiBAZmV0Y2gg aXMgdHJ1ZS4KPj4gwqAgKi8KPj4gwqB2b2lkIGludGVsX3VjX2Z3X2ZldGNoKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg c3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdykKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdywgYm9vbCBmZXRjaCkKPj4gwqB7Cj4+IMKgwqDC oMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gZGV2X3ByaXYtPmRybS5wZGV2Owo+PiDCoMKgwqDC oCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+PiBAQCAtMTU0LDE3ICsxNTYsMjQg QEAgdm9pZCBpbnRlbF91Y19md19mZXRjaChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAKPj4gKmRl dl9wcml2LAo+PiDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZmFpbDsKPj4gwqDCoMKgwqAgfQo+PiAt wqDCoMKgIG9iaiA9IGk5MTVfZ2VtX29iamVjdF9jcmVhdGVfZnJvbV9kYXRhKGRldl9wcml2LCBm dy0+ZGF0YSwgCj4+IGZ3LT5zaXplKTsKPj4gLcKgwqDCoCBpZiAoSVNfRVJSKG9iaikpIHsKPj4g LcKgwqDCoMKgwqDCoMKgIGVyciA9IFBUUl9FUlIob2JqKTsKPj4gLcKgwqDCoMKgwqDCoMKgIERS TV9ERUJVR19EUklWRVIoIiVzIGZ3IG9iamVjdF9jcmVhdGUgZXJyPSVkXG4iLAo+PiAtwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaW50ZWxfdWNfZndfdHlwZV9yZXByKHVjX2Z3LT50 eXBlKSwgZXJyKTsKPj4gLcKgwqDCoMKgwqDCoMKgIGdvdG8gZmFpbDsKPj4gK8KgwqDCoCB1Y19m dy0+c2l6ZSA9IGZ3LT5zaXplOwo+PiArwqDCoMKgIHVjX2Z3LT5mZXRjaF9zdGF0dXMgPSBJTlRF TF9VQ19GSVJNV0FSRV9WRVJJRklFRDsKPgo+IGJ0dywgSSdtIG5vdCBzdXJlIHRoYXQgdGhpcyBu ZXcgc3RhdGUgaXMgbmVlZGVkIGF0IGFsbCwgYXMgeW91IGRvbid0Cj4gcGxhbiB0byB1c2UgdGhh dCBmdyBvYmogaWYgeW91IG9ubHkgbG9hZGVkIGZ3IGJsb2IgdG8gcmVhZCBoZWFkZXIuLi4KPgp3 ZSB3aWxsIGhhdmUgdGhlIGhlYWRlciBpbmZvIHN0b3JlZCBhbG9uZyB3aXRoIHRoZSBpbnRlbF9n dWMvaW50ZWxfZncgCmFueXdheS4KdGhpcyBzdGF0ZSBvbmx5IHN1Z2dlc3RzIHRoYXQgdmFsaWQg RlcgaW1hZ2VzIGFyZSBhdmFpbGFibGUgYnV0IHdhc24ndCAKbG9hZGVkCnRvIHRoZSBtZW1vcnku CgpSZWdhcmRzLAotSmFja2llCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK