References: <cover.1452359845.git.digetx@gmail.com>
	<5c18054d536f3f940d3059235f0ac4aad42c835c.1452359845.git.digetx@gmail.com>
	<20160112035858.GG3308@pcrost-box>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <5695420E.2020709@gmail.com>
Date: Tue, 12 Jan 2016 21:12:30 +0300
MIME-Version: 1.0
In-Reply-To: <20160112035858.GG3308@pcrost-box>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v10 5/7] hw/ptimer: Legalize running with
	delta = load = 0
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>

12.01.2016 06:58, Peter Crosthwaite пишет:
> On Sat, Jan 09, 2016 at 08:39:53PM +0300, Dmitry Osipenko wrote:
>> Currently ptimer would print error message and clear enable flag for an
>> arming timer that has delta = load = 0. That actually could be a valid case
>> for some hardware, like instant IRQ trigger for oneshot timer or continuous
>> in periodic mode. Support those cases by printing error message only when
>> period = 0.
>>
>
> Isn't the continuous-periodic the same as period = 0, so if we were to really
> support this, there should be no error message. This would simplify as we
> can remove the conditionals of 0 period completely and rely only on the
> too-fast clamps you add in previous patches.
>

I don't think that clamping is needed. Instead doing the ptimer_tick might be 
necessary, so ptimer user could handle that case on it own.

BTW, that printf isn't quite reliable, hw_error or other way of execution abort 
should been used instead.

Thanks for the comment.

-- 
Dmitry