References: <cover.1453402860.git.digetx@gmail.com>
	<9fb47bb0f1355221ef074766d5cc49f2de97e79b.1453402860.git.digetx@gmail.com>
	<CAPokK=q0EzXWeAFibVYKXmvwh5=vM6LsEqJB9k5dNGF6AiHeoA@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <56A67ACA.4090801@gmail.com>
Date: Mon, 25 Jan 2016 22:43:06 +0300
MIME-Version: 1.0
In-Reply-To: <CAPokK=q0EzXWeAFibVYKXmvwh5=vM6LsEqJB9k5dNGF6AiHeoA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v11 2/7] hw/ptimer: Perform counter wrap
 around if timer already expired
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

Hello Peter,

24.01.2016 08:29, Peter Crosthwaite пишет:

[snip]

>> +            if (expired && (counter != 0)) {
>> +                /* Wrap around periodic counter.  */
>> +                counter = s->limit - counter % s->limit;
>> +            }

Noticed another nit here. This should be:

counter = s->limit - (counter - 1) % s->limit;

So wraparound for counter = -1 is counter = limit (not limit - 1). Will fix it 
in V12.

I suppose your r-b is still valid, otherwise please let me know.

-- 
Dmitry