From: boris.ostrovsky@oracle.com (Boris Ostrovsky) Date: Mon, 8 Feb 2016 11:41:16 -0500 Subject: [Cocci] [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy In-Reply-To: <20160208163526.GI28980@pd.tnic> References: <20160206085930.GF25240@wotan.suse.de> <20160206220437.GA4435@pd.tnic> <56B8B6BF.6030007@oracle.com> <20160208155507.GF28980@pd.tnic> <56B8BCDB.9040701@citrix.com> <56B8BE58.6070003@oracle.com> <56B8C1BC.9040603@citrix.com> <56B8C2C8.8050406@oracle.com> <20160208163526.GI28980@pd.tnic> Message-ID: <56B8C52C.1070301@oracle.com> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On 02/08/2016 11:35 AM, Borislav Petkov wrote: > On Mon, Feb 08, 2016 at 11:31:04AM -0500, Boris Ostrovsky wrote: >> I think we are OK for PV because this code will be executed after pvops are >> set and so we will be calling xen_cpuid(). > Not for the early loader - it is too early for pvops then. So you're > saying something like that won't work? Keep in mind that Xen PV doesn't go through startup_32|64(). It starts at xen_start_kernel (save for a small stub before that), which sets pvops. It "joins" regular/baremetal code in i386_start_kernel/x86_64_start_reservation(). -boris