From: David Vrabel Subject: Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check Date: Fri, 19 Feb 2016 13:27:21 +0000 Message-ID: <56C71839.3090609@citrix.com> References: <1455887316-9223-1-git-send-email-mcgrof@kernel.org> <1455887316-9223-9-git-send-email-mcgrof@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455887316-9223-9-git-send-email-mcgrof@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: "Luis R. Rodriguez" , bp@alien8.de Cc: rusty@rustcorp.com.au, x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, xen-devel@lists.xensource.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On 19/02/16 13:08, Luis R. Rodriguez wrote: > The current check is a super long winded way of asking if this > is on lguest. The flags is used for legacy features, this is > likely inspired by the ACPI IA-PC boot architecture flags, where > as for RTC it annotates No CMOS real-time clock present. I don't > expect we will be implementing more legacy features, its simply > pointless so just remove this legacy flag feature thing as well. No. This check is needed for Xen PV domU guests and without it PV guests don't get a console (as I think the history of the change that introduced this makes clear). I think this trend towards a coarse-grained subarch instead of a set of feature bits is the wrong direction. David